Fix vault pillar rendering as all or nothing for each minion #63165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensures that pillar rendering doesn't fail if all secrets aren't available to each minion.
The session cache was holding the token under certain circumstances after failing to retrieve a secret. The token was then invalid, but it was not being removed from cache, thus resulting in permission denied errors.
What issues does this PR fix or reference?
Fixes: #61821
Previous Behavior
The pillar would fail to render after encountering the first secret a minion was denied access to.
New Behavior
Now the pillar renders properly.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.