Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vault pillar rendering as all or nothing for each minion #63165

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

MKLeb
Copy link
Contributor

@MKLeb MKLeb commented Dec 1, 2022

What does this PR do?

Ensures that pillar rendering doesn't fail if all secrets aren't available to each minion.

The session cache was holding the token under certain circumstances after failing to retrieve a secret. The token was then invalid, but it was not being removed from cache, thus resulting in permission denied errors.

What issues does this PR fix or reference?

Fixes: #61821

Previous Behavior

The pillar would fail to render after encountering the first secret a minion was denied access to.

New Behavior

Now the pillar renders properly.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@MKLeb MKLeb requested a review from a team as a code owner December 1, 2022 02:28
@MKLeb MKLeb requested review from waynew and removed request for a team December 1, 2022 02:28
@Ch3LL Ch3LL merged commit 4b63725 into saltstack:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Vault as external pillar is all or nothing
2 participants