Disable FQDNs grains on macOS by default #63204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twangboy
approved these changes
Dec 16, 2022
s0undt3ch
approved these changes
Jan 24, 2023
Ch3LL
approved these changes
Jan 26, 2023
|
re-run pr-photon-3-x86_64-py3-pytest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Defaults
enable_fqdns_grainstoFalseon macOS.What issues does this PR fix or reference?
Not sure if this should be considered a fix or a workaround tbh.
Reference: #62168
Previous Behavior
By default, spends a lot of time trying to resolve irrelevant addresses
New Behavior
By default, skips FQDN resolution
Merge requirements satisfied?
Commits signed with GPG?
Yes