Skip to content

Disable FQDNs grains on macOS by default - #63204

Merged
Ch3LL merged 4 commits into
saltstack:masterfrom
lkubb:macos-fqdn-grains
Feb 2, 2023
Merged

Ch3LL merged 4 commits into
saltstack:masterfrom
lkubb:macos-fqdn-grains

Conversation

@lkubb

@lkubb lkubb commented Dec 5, 2022 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Defaults enable_fqdns_grains to False on macOS.

What issues does this PR fix or reference?

Not sure if this should be considered a fix or a workaround tbh.

Reference: #62168

Previous Behavior

By default, spends a lot of time trying to resolve irrelevant addresses

New Behavior

By default, skips FQDN resolution

Merge requirements satisfied?

Commits signed with GPG?

Yes

@lkubb
lkubb requested a review from a team as a code owner December 5, 2022 17:23
@lkubb
lkubb requested review from twangboy and removed request for a team December 5, 2022 17:23
@twangboy twangboy added the Sulfur v3006.0 release code name and version label Jan 24, 2023
@twangboy twangboy added this to the Sulphur v3006.0 milestone Jan 24, 2023
@Ch3LL

Ch3LL commented Jan 26, 2023

Copy link
Copy Markdown
Contributor

re-run pr-photon-3-x86_64-py3-pytest

@Ch3LL
Ch3LL merged commit c1fc63d into saltstack:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sulfur v3006.0 release code name and version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants