Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add msi build scripts #63366

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Conversation

twangboy
Copy link
Contributor

What does this PR do?

Brings the MSI build scripts from https://github.com/saltstack/salt-windows-msi to Salt

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@twangboy twangboy requested a review from a team as a code owner December 23, 2022 01:21
@twangboy twangboy requested review from MKLeb and removed request for a team December 23, 2022 01:21
@twangboy twangboy added the Sulfur v3006.0 release code name and version label Dec 23, 2022
@twangboy twangboy added this to the Sulphur v3006.0 milestone Dec 23, 2022
@Ch3LL
Copy link
Contributor

Ch3LL commented Dec 23, 2022

pre-commit is failing and there is a merge conflict.

Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding binaries to a repo? such as python.exe, binlevel.exe, etc?

pkg/windows/msi/tests/config_tests/.gitignore Outdated Show resolved Hide resolved
requirements/windows.txt Outdated Show resolved Hide resolved
@Ch3LL
Copy link
Contributor

Ch3LL commented Jan 3, 2023

Looks like you did make a separate PR for pythonnet upgrade: #63355

Can you remove the change from here?

@twangboy
Copy link
Contributor Author

twangboy commented Jan 4, 2023

Once that PR is merged, those will disappear from this PR.

@Ch3LL
Copy link
Contributor

Ch3LL commented Jan 4, 2023

Why are we adding binaries to a repo? such as python.exe, binlevel.exe, etc?

@twangboy
Copy link
Contributor Author

twangboy commented Jan 4, 2023

Most of the binaries are just junk... required by the installer code because it's expecting a file with that name. The Python binaries are necessary because the build script runs the python to get the arch it was built for. In a typical environment, this would be the Python.exe/.dll created by relenv. For the test environment, we don't really care. It just needs to return the arch of the system.

@garethgreenaway garethgreenaway merged commit 60a1959 into saltstack:master Jan 5, 2023
@twangboy twangboy deleted the msi_support branch March 23, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sulfur v3006.0 release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants