Add msi build scripts#63366
Conversation
|
pre-commit is failing and there is a merge conflict. |
2989fad to
51ac3df
Compare
Ch3LL
left a comment
There was a problem hiding this comment.
Why are we adding binaries to a repo? such as python.exe, binlevel.exe, etc?
|
Looks like you did make a separate PR for pythonnet upgrade: #63355 Can you remove the change from here? |
|
Once that PR is merged, those will disappear from this PR. |
|
Why are we adding binaries to a repo? such as python.exe, binlevel.exe, etc? |
|
Most of the binaries are just junk... required by the installer code because it's expecting a file with that name. The Python binaries are necessary because the build script runs the python to get the arch it was built for. In a typical environment, this would be the Python.exe/.dll created by relenv. For the test environment, we don't really care. It just needs to return the arch of the system. |
What does this PR do?
Brings the MSI build scripts from https://github.com/saltstack/salt-windows-msi to Salt
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes