handle ptf packages inside of normal pkg.remove function #63460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcalmer
force-pushed
the
implement-zypper-removeptf-option2
branch
from
ab70af1 to
a4a8b92
Compare
3 tasks
mcalmer
force-pushed
the
implement-zypper-removeptf-option2
branch
2 times, most recently
from
fc99403 to
df1d3e8
Compare
Ch3LL
reviewed
Jan 12, 2023
Contributor
Ch3LL
left a comment
Ch3LL
left a comment
There was a problem hiding this comment.
I like this approach much better. Thanks :) I just left a couple more suggestions.
mcalmer
force-pushed
the
implement-zypper-removeptf-option2
branch
2 times, most recently
from
a932b81 to
8cdbeb8
Compare
This was referenced Jan 16, 2023
mcalmer
force-pushed
the
implement-zypper-removeptf-option2
branch
from
8cdbeb8 to
58feb8c
Compare
3 tasks
Ch3LL
previously approved these changes
Mar 22, 2023
Co-authored-by: Megan Wilhite <mwilhite@vmware.com>
Ch3LL
force-pushed
the
implement-zypper-removeptf-option2
branch
from
c055689 to
9d0f656
Compare
dwoz
approved these changes
Dec 16, 2023
agraul
pushed a commit
to agraul/salt
that referenced
this pull request
Jan 27, 2025
* handle ptf packages inside of normal pkg.remove function * add testcase for remove and removeptf * add changelog * adapt old tests to changed function * Update Docs Co-authored-by: Megan Wilhite <mwilhite@vmware.com> BACKPORT-UPSTREAM=saltstack#63460
agraul
added a commit
to agraul/salt
that referenced
this pull request
Jan 27, 2025
Fixes a problem in `_find_ptf_packages()` when passing multiple packages to `zypperpkg.remove` / `zypperpkg.purge`. The problem occurs when a passed package is not installed, in that case the output of the `rpm` subprocess is not parsed correctly. BACKPORT-UPSTREAM=saltstack#63460 DOWNSTREAM-REF=openSUSE/salt#578
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Enhance zypper pkg module to remove PTF (Product Temporary Fix) packages.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.