Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set enable_fqdns_grains to be False by default. #63555

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Jan 25, 2023

What does this PR do?

Set enable_fqdns_grains to be False by default.

What issues does this PR fix or reference?

Fixes: #63595

Previous Behavior

enable_fqdns_grains was True by default on non-Windows and non-proxy hosts.

New Behavior

enable_fqdns_grains is not set as False by default.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from a team as a code owner January 25, 2023 23:50
@garethgreenaway garethgreenaway requested review from dwoz and removed request for a team January 25, 2023 23:50
dmurphy18
dmurphy18 previously approved these changes Jan 26, 2023
Copy link
Contributor

@dmurphy18 dmurphy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, about time we did that

twangboy
twangboy previously approved these changes Jan 26, 2023
@garethgreenaway garethgreenaway added this to the Sulphur v3006.0 milestone Jan 31, 2023
@garethgreenaway garethgreenaway added the Sulfur v3006.0 release code name and version label Jan 31, 2023
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog

@garethgreenaway garethgreenaway dismissed stale reviews from twangboy and dmurphy18 via bbe7f64 January 31, 2023 18:53
@garethgreenaway garethgreenaway requested a review from Ch3LL January 31, 2023 18:53
@garethgreenaway garethgreenaway changed the title Set set_enable_fqdns_grains to be False by default. Set enable_fqdns_grains to be False by default. Jan 31, 2023
@garethgreenaway garethgreenaway merged commit 4ab9abc into saltstack:master Feb 2, 2023
@garethgreenaway garethgreenaway deleted the set_enable_fqdns_grains_false branch February 2, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sulfur v3006.0 release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Disable enable_fqdns_grains to False by default
4 participants