Digitalocean update #63745
Merged
Digitalocean update #63745
+139
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/salt into digitalocean_update
whytewolf
approved these changes
Jul 7, 2023
Contributor
Author
|
We're almost there @dwoz . |
Ch3LL
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the implements the vpc_uuid parameter when creating a droplet. This parameter selects the correct virtual private cloud (private network interface). This is because the private_networking is now depricated as it's behaviour isn't deterministic in a case where there are multiple VPC's existing.
What issues does this PR fix or reference?
Fixes: #63714
Previous Behavior
private_networking selects the internal vpc.
New Behavior
vpc_uuid selects the correct VPC. Previously there was only one VPC so this wasn't necessary.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.