[master] file.keyvalue should allow creating a file if it doesn't exist - #64028
Merged
Ch3LL merged 12 commits intoJun 14, 2023
Merged
Conversation
…t doesn't exist
salt-project-bot-prod-environment
Bot
changed the title
Ch3LL
reviewed
May 9, 2023
Ch3LL
previously approved these changes
May 17, 2023
Contributor
|
Yeah if you don't mind. Recently a change was made to the pre commit config file to make the code compatible with 3.8 and up, since 3.7 is going end of life in a few weeks. |
MKLeb
previously approved these changes
Jun 9, 2023
Ch3LL
previously approved these changes
Jun 9, 2023
Contributor
|
@nicholasmhughes sorry but there seems to be a merge conflict. Mind resolving that? |
Contributor
Author
|
@Ch3LL resolved. 👍 |
Ch3LL
approved these changes
Jun 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
create_if_missingparameter to handle basic file creation forfile.keyvalueWhat issues does this PR fix or reference?
Fixes: #63545
Previous Behavior
file.keyvaluecould not create a file, sofile.touchorfile.managedwithout content were often used.New Behavior
Basic file creation is now possible, although management of permissions and ownership is not.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.