Skip to content

[3006.x]User salt user/group for running salt-master #64037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Apr 15, 2023
Merged

[3006.x]User salt user/group for running salt-master #64037

merged 26 commits into from
Apr 15, 2023

Conversation

Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Apr 6, 2023 •
edited by dwoz
Loading

Relates to #64045

@Ch3LL Ch3LL requested a review from a team as a code owner April 6, 2023 19:24
@Ch3LL Ch3LL requested review from dwoz and removed request for a team April 6, 2023 19:24
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [WIP] User salt user/group for running salt-master [3006.x][WIP] User salt user/group for running salt-master Apr 6, 2023
@garethgreenaway garethgreenaway added the Sulfur v3006.0 release code name and version label Apr 13, 2023
@garethgreenaway garethgreenaway added this to the Sulfur v3006.0 milestone Apr 13, 2023
@Ch3LL Ch3LL temporarily deployed to ci April 13, 2023 15:02 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 13, 2023 15:54 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 13, 2023 17:18 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 13, 2023 19:33 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 13, 2023 20:34 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 13, 2023 21:37 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 13, 2023 22:45 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 14, 2023 04:29 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 14, 2023 14:53 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 14, 2023 15:20 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 14, 2023 19:51 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 14, 2023 21:12 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 14, 2023 22:43 — with GitHub Actions Inactive
@Ch3LL Ch3LL mentioned this pull request Apr 15, 2023
Merged
@Ch3LL Ch3LL temporarily deployed to ci April 15, 2023 02:32 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 15, 2023 02:32 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci April 15, 2023 02:36 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci April 15, 2023 03:35 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci April 15, 2023 03:35 — with GitHub Actions Inactive
@s0undt3ch
Only windows doesn't have all binaries. Assert against that too.
4d1d56d 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Only show the warnings when running the download package tests
61b878d 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Wipe the extras directory between tests
f8418f7 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch s0undt3ch temporarily deployed to ci April 15, 2023 17:01 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci April 15, 2023 17:01 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci April 15, 2023 17:01 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci April 15, 2023 18:32 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci April 15, 2023 18:32 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci April 15, 2023 18:32 — with GitHub Actions Inactive
@Ch3LL Ch3LL changed the title [3006.x][WIP] User salt user/group for running salt-master [3006.x]User salt user/group for running salt-master Apr 15, 2023
dwoz
dwoz reviewed Apr 15, 2023
View reviewed changes
pkg/tests/conftest.py
"""
start up and configure salt_api
"""
shutil.rmtree(str(extras_pypath.parent), ignore_errors=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MKLeb in the future, please add a comment along with a special case like there when it's not obvious why the code is getting included. Either a comment or something in the docstring.

@s0undt3ch s0undt3ch merged commit 10e75b2 into saltstack:3006.x Apr 15, 2023
@Ch3LL Ch3LL mentioned this pull request Apr 15, 2023
Closed
This was referenced Apr 29, 2023
Closed
Merged
Closed
@olipinski olipinski mentioned this pull request May 23, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@dwoz dwoz dwoz approved these changes

Assignees
No one assigned
Labels
Sulfur v3006.0 release code name and version
Projects
None yet
Milestone
Sulfur v3006.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Ch3LL @s0undt3ch @dwoz @garethgreenaway @MKLeb