Skip to content

[master] Fix cmd.run doesn't output changes in test mode #64151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
s0undt3ch merged 1 commit into from
Apr 27, 2023
Merged

[master] Fix cmd.run doesn't output changes in test mode #64151

s0undt3ch merged 1 commit into from
Apr 27, 2023

Conversation

@nicholasmhughes
Copy link
Contributor

@nicholasmhughes nicholasmhughes commented Apr 24, 2023

What does this PR do?

See issue for details.

What issues does this PR fix or reference?

Fixes: #64150

Previous Behavior

          ID: echo hello
    Function: cmd.run
      Result: None
     Comment: Command "echo hello" would have been executed
     Started: 18:23:03.961085
    Duration: 0.481 ms
     Changes:

New Behavior

          ID: echo hello
    Function: cmd.run
      Result: None
     Comment: Command "echo hello" would have been executed
     Started: 18:31:14.193750
    Duration: 0.52 ms
     Changes:   
              ----------
              cmd:
                  echo hello

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@nicholasmhughes nicholasmhughes requested a review from a team as a code owner April 24, 2023 18:55
@nicholasmhughes nicholasmhughes requested review from cmcmarrow and removed request for a team April 24, 2023 18:55
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Fix cmd.run doesn't output changes in test mode [master] Fix cmd.run doesn't output changes in test mode Apr 24, 2023
@nicholasmhughes nicholasmhughes temporarily deployed to ci April 24, 2023 20:39 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci April 24, 2023 20:48 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci April 24, 2023 21:58 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci April 25, 2023 00:23 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci April 25, 2023 00:23 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci April 25, 2023 00:23 — with GitHub Actions Inactive
cmcmarrow
cmcmarrow approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@cmcmarrow cmcmarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@cmcmarrow cmcmarrow mentioned this pull request Apr 26, 2023
Merged
3 tasks
@s0undt3ch s0undt3ch merged commit 98ecf8d into saltstack:master Apr 27, 2023
@nicholasmhughes nicholasmhughes deleted the fix-cmd.run-test-mode-changes branch May 2, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twangboy twangboy twangboy approved these changes

+1 more reviewer

@cmcmarrow cmcmarrow cmcmarrow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Sulfur v3006.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] cmd.run doesn't output changes in test mode

4 participants

@nicholasmhughes @twangboy @cmcmarrow @s0undt3ch