[master] Make x509_v2 compound match detection use match runner - #64302
Merged
Conversation
salt-project-bot-prod-environment
Bot
changed the title
Contributor
Author
|
@garethgreenaway Mind commenting on/reviewing this relatively small PR? It would make sense to get this breaking change to the x509_v2 modules out of the way as early as possible after their introduction, not sure how far away 3007 is. Since they are security snakeoil, I don't think (hope) too many people use compound expressions currently, esp. since they are discouraged from in the v2 docs (not the original ones though). |
Contributor
Author
|
@garethgreenaway Friendly ping. :) |
twangboy
approved these changes
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces the current
x509_v2compound match validation (using thematch.compoundexecution module on the requesting minion, inherited from the old modules) with validation that is executed on the master (newmatchrunner, merged in #63297).This is a breaking change (master config needs to be updated, only exact pillar value matching supported), but the old method is severely flawed and should not exist imo.
What issues does this PR fix or reference?
Fixes: #63278
Previous Behavior
CA minion asks the minion requesting a certificate if it is authorized to receive it under a signing policy.
New Behavior
CA minion asks the master if the requesting minion is authorized to receive a certificate under a signing policy.
Merge requirements satisfied?
Commits signed with GPG?
Yes