Skip to content

[master] Drop Python 3.7 support.#64417

Merged
s0undt3ch merged 1 commit intomasterfrom
hotfix/drop-3.7
Jun 5, 2023
Merged

[master] Drop Python 3.7 support.#64417
s0undt3ch merged 1 commit intomasterfrom
hotfix/drop-3.7

Conversation

@s0undt3ch
Copy link
Contributor

What does this PR do?

See title.

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch s0undt3ch requested a review from a team as a code owner June 4, 2023 13:13
@s0undt3ch s0undt3ch requested review from MKLeb and removed request for a team June 4, 2023 13:13
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Drop Python 3.7 support. [master] Drop Python 3.7 support. Jun 4, 2023
@s0undt3ch
Copy link
Contributor Author

Same cloud test failures as seen on the master branch

https://jenkins.saltproject.io/job/pr-centosstream-9-x86_64-py3-cloud-pytest/job/master/409

Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be relevant to add a changelog and a note to the release notes that python 3.7 is no longer supported in 3007.0. I'm okay if you want to do this in a follow up PR as well.

@s0undt3ch
Copy link
Contributor Author

I think it would be relevant to add a changelog and a note to the release notes that python 3.7 is no longer supported in 3007.0. I'm okay if you want to do this in a follow up PR as well.

Since this is already passing and has 3 review, yeah, I'll submit it separately.

@s0undt3ch
Copy link
Contributor Author

I think it would be relevant to add a changelog and a note to the release notes that python 3.7 is no longer supported in 3007.0. I'm okay if you want to do this in a follow up PR as well.

Since this is already passing and has 3 review, yeah, I'll submit it separately.

Wait, only 2, not 3. But a separate PR will save build time

Copy link
Contributor

@dmurphy18 dmurphy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this line in noxfile.py

_PYTHON_VERSIONS = ("3", "3.5", "3.6", "3.7", "3.8", "3.9", "3.10")

need to change

@s0undt3ch
Copy link
Contributor Author

@dmurphy18 will submit the issue you flagged when I also submit the changelog.

Merging.

@s0undt3ch s0undt3ch merged commit e18d829 into master Jun 5, 2023
@s0undt3ch s0undt3ch deleted the hotfix/drop-3.7 branch June 5, 2023 19:55
@s0undt3ch
Copy link
Contributor Author

#64424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants