Skip to content

[master] Add ability to return False result in test mode of configurable_test_state - #64419

Merged
Ch3LL merged 1 commit into
saltstack:masterfrom
nicholasmhughes:add-test-fail-to-test-cfg-state
Jun 6, 2023
Merged

[master] Add ability to return False result in test mode of configurable_test_state#64419
Ch3LL merged 1 commit into
saltstack:masterfrom
nicholasmhughes:add-test-fail-to-test-cfg-state

Conversation

@nicholasmhughes

Copy link
Copy Markdown
Contributor

What does this PR do?

See issue for details

What issues does this PR fix or reference?

Fixes: #64418

Previous Behavior

The result of test.configurable_test_state could only be None or True in test mode.

New Behavior

Now a False result can be allowed in test mode.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@nicholasmhughes
nicholasmhughes requested a review from a team as a code owner June 4, 2023 19:25
@nicholasmhughes
nicholasmhughes requested review from dwoz and removed request for a team June 4, 2023 19:25
@salt-project-bot-prod-environment salt-project-bot-prod-environment Bot changed the title Add ability to return False result in test mode of configurable_test_state [master] Add ability to return False result in test mode of configurable_test_state Jun 4, 2023
@nicholasmhughes
nicholasmhughes temporarily deployed to ci June 5, 2023 19:58 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci June 5, 2023 20:07 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci June 5, 2023 20:07 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci June 5, 2023 20:08 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci June 5, 2023 20:24 — with GitHub Actions Inactive
@nicholasmhughes
nicholasmhughes temporarily deployed to ci June 5, 2023 20:32 — with GitHub Actions Inactive
@Ch3LL
Ch3LL merged commit 9ffbd21 into saltstack:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] configurable_test_state should be able to return False result in test mode

2 participants