Skip to content

[master] Remove salt.modules.napalm_mod.netmiko_conn and pyeapi_conn #64466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 27, 2023
Merged

[master] Remove salt.modules.napalm_mod.netmiko_conn and pyeapi_conn #64466

merged 6 commits into from
Jun 27, 2023

Conversation

cmcmarrow
Copy link
Contributor

@cmcmarrow cmcmarrow commented Jun 12, 2023 •
edited
Loading

What does this PR do?

Remove salt.modules.napalm_mod.netmiko_conn and pyeapi_conn

What issues does this PR fix or reference?

Fixes: #64460

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@cmcmarrow cmcmarrow requested a review from a team as a code owner June 12, 2023 16:34
@cmcmarrow cmcmarrow requested review from twangboy and removed request for a team June 12, 2023 16:34
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Remove salt.modules.napalm_mod.netmiko_conn and pyeapi_conn [3006.x] Remove salt.modules.napalm_mod.netmiko_conn and pyeapi_conn Jun 12, 2023
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 16:58 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 16:58 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 17:01 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 17:03 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 17:15 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 17:21 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 18:37 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 18:37 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 18:37 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 18:37 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 18:38 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 18:38 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 19:38 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 19:38 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 19:38 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 19:38 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 19:38 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 12, 2023 19:38 — with GitHub Actions Inactive
@Ch3LL
Copy link
Contributor

Ch3LL commented Jun 12, 2023

This needs to be pointed to the master branch.

MKLeb
MKLeb previously approved these changes Jun 12, 2023
View reviewed changes
@cmcmarrow cmcmarrow changed the base branch from 3006.x to master June 16, 2023 16:18
@cmcmarrow cmcmarrow dismissed MKLeb’s stale review June 16, 2023 16:18

The base branch was changed.

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [3006.x] Remove salt.modules.napalm_mod.netmiko_conn and pyeapi_conn [master] Remove salt.modules.napalm_mod.netmiko_conn and pyeapi_conn Jun 16, 2023
@cmcmarrow cmcmarrow temporarily deployed to ci June 16, 2023 17:47 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 16, 2023 17:47 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 20, 2023 22:33 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 20, 2023 22:34 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 21, 2023 16:15 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 21, 2023 16:15 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 21, 2023 16:17 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 21, 2023 16:18 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 21, 2023 16:33 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 21, 2023 16:33 — with GitHub Actions Inactive
Ch3LL
Ch3LL suggested changes Jun 21, 2023
View reviewed changes
@cmcmarrow cmcmarrow temporarily deployed to ci June 21, 2023 21:25 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 21, 2023 21:25 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 21, 2023 21:25 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 21, 2023 21:25 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 21, 2023 21:26 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 21, 2023 21:26 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 22, 2023 18:23 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 22, 2023 18:23 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 22, 2023 18:23 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 22, 2023 18:23 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 22, 2023 18:42 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 22, 2023 18:47 — with GitHub Actions Inactive
@Ch3LL Ch3LL merged commit 0892d07 into saltstack:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@garethgreenaway garethgreenaway garethgreenaway approved these changes

@whytewolf whytewolf whytewolf approved these changes

@Ch3LL Ch3LL Ch3LL approved these changes

@MKLeb MKLeb MKLeb approved these changes

@twangboy twangboy Awaiting requested review from twangboy twangboy was automatically assigned from saltstack/team-core

Assignees
No one assigned
Labels
Chlorine v3007.0 has-failing-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TECH DEBT] Remove salt.modules.napalm_mod.netmiko_conn and pyeapi_conn
6 participants
@cmcmarrow @Ch3LL @s0undt3ch @garethgreenaway @whytewolf @MKLeb