Skip to content

[master]gpg_decrypt_must_succeed default from False to True #64471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmcmarrow merged 6 commits into from
Jun 21, 2023
Merged

[master]gpg_decrypt_must_succeed default from False to True #64471

cmcmarrow merged 6 commits into from
Jun 21, 2023

Conversation

@cmcmarrow
Copy link
Contributor

@cmcmarrow cmcmarrow commented Jun 12, 2023 •
edited
Loading

What does this PR do?

change default from False to True for gpg_decrypt_must_succeed

What issues does this PR fix or reference?

Fixes: #64462

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@cmcmarrow cmcmarrow requested a review from a team as a code owner June 12, 2023 20:59
@cmcmarrow cmcmarrow requested review from whytewolf and removed request for a team June 12, 2023 20:59
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title pg_decrypt_must_succeed default from False to True [3006.x] pg_decrypt_must_succeed default from False to True Jun 12, 2023
@cmcmarrow cmcmarrow changed the title [3006.x] pg_decrypt_must_succeed default from False to True gpg_decrypt_must_succeed default from False to True Jun 12, 2023
MKLeb
MKLeb previously approved these changes Jun 12, 2023
View reviewed changes
whytewolf
whytewolf previously approved these changes Jun 12, 2023
View reviewed changes
@Ch3LL
Copy link
Contributor

Ch3LL commented Jun 13, 2023

This needs to be pointed to the master branch

@cmcmarrow cmcmarrow temporarily deployed to ci June 13, 2023 14:57 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 13, 2023 14:57 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 13, 2023 14:57 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 13, 2023 14:57 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 13, 2023 15:14 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 13, 2023 15:22 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow changed the base branch from 3006.x to master June 16, 2023 16:16
@cmcmarrow cmcmarrow dismissed stale reviews from MKLeb and whytewolf June 16, 2023 16:16

The base branch was changed.

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title gpg_decrypt_must_succeed default from False to True [master]gpg_decrypt_must_succeed default from False to True Jun 16, 2023
@cmcmarrow cmcmarrow temporarily deployed to ci June 16, 2023 17:47 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 16, 2023 17:47 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 16, 2023 17:47 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 16, 2023 17:47 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 16, 2023 18:05 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 16, 2023 18:07 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 16, 2023 19:09 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 16, 2023 19:09 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 19, 2023 06:22 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 19, 2023 06:22 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 19, 2023 06:22 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 19, 2023 06:22 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 19, 2023 06:22 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 19, 2023 06:29 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 19, 2023 06:29 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 19, 2023 06:29 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 19, 2023 06:29 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 19, 2023 06:29 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 19, 2023 06:29 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 20, 2023 21:22 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 20, 2023 21:22 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 20, 2023 21:23 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 20, 2023 21:40 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 20, 2023 21:44 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 20, 2023 21:53 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 21, 2023 02:29 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 21, 2023 02:29 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 21, 2023 02:29 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 21, 2023 02:29 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 21, 2023 02:29 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci June 21, 2023 02:29 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow merged commit b0bf7eb into saltstack:master Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@whytewolf whytewolf whytewolf approved these changes

@MKLeb MKLeb MKLeb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Chlorine v3007.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[TECH DEBT] Change gpg_decrypt_must_succeed to default to True

4 participants

@cmcmarrow @Ch3LL @whytewolf @MKLeb