[master] Add syncing of custom ssh wrappers - #64518
Merged
Merged
Conversation
salt-project-bot-prod-environment
Bot
changed the title
Ch3LL
suggested changes
Jun 22, 2023
Ch3LL
left a comment
Ch3LL
left a comment
Contributor
There was a problem hiding this comment.
Could you add a test that syncs a custom salt-ssh wraper and then salt-ssh actually uses that wrapper?
Also, this is great, thanks once again.
Contributor
Author
|
Whoops, I was a bit too hasty in creating this PR, sorry. It was probably the surprise to find that 95% of the functionality was there already...
|
Ch3LL
approved these changes
Jun 26, 2023
whytewolf
approved these changes
Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
sync_wrapperto thesaltutilrunner/execution/state modules.From what I can tell, the loader is already configured to load them.
What issues does this PR fix or reference?
Fixes: #45450
Reference: #61637
Previous Behavior
<cache_dir>/extmods/wrapperis respected by the loader, but cannot be synced from the fileserverNew Behavior
<cache_dir>/extmods/wrappercan be syncedMerge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes