[master] Deprecated in favor of Salt Extension Decorator#64569
Merged
Ch3LL merged 13 commits intoJun 30, 2023
Merged
Conversation
…or of a Salt extension
salt-project-bot-prod-environment
Bot
changed the title
Ch3LL
previously approved these changes
Jun 28, 2023
Ch3LL
left a comment
Ch3LL
left a comment
Contributor
There was a problem hiding this comment.
We need to document this so users know how to properly deprecate modules in favor of Salt extensions. I'm approving this as I'm okay if we do this in a separate PR as it might require more work since we don't have any documentation related to writing a Salt extension currently that I'm aware of.
dmurphy18
previously approved these changes
Jun 28, 2023
dmurphy18
left a comment
dmurphy18
left a comment
Contributor
There was a problem hiding this comment.
What about modules already with deprecation since moved to extensions in 3006, for example the ESXi module and it's cohorts, should they stay unchanged or be updated once this is merged ?
s0undt3ch
previously approved these changes
Jun 28, 2023
garethgreenaway
dismissed stale reviews from s0undt3ch, dmurphy18, and Ch3LL
via
ec6c7e8
s0undt3ch
suggested changes
Jun 28, 2023
Ch3LL
previously approved these changes
Jun 28, 2023
twangboy
requested changes
Jun 28, 2023
I3urny
reviewed
Jun 29, 2023
s0undt3ch
previously requested changes
Jun 29, 2023
I3urny
suggested changes
Jun 29, 2023
I3urny
left a comment
I3urny
left a comment
Contributor
There was a problem hiding this comment.
Just needs a minor fix in the documentation. Looks good otherwise.
I3urny
approved these changes
Jun 29, 2023
dmurphy18
approved these changes
Jun 29, 2023
s0undt3ch
approved these changes
Jun 30, 2023
twangboy
approved these changes
Jun 30, 2023
Ch3LL
approved these changes
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding a new decorator to indicate when a module is deprecated in favor of a Salt extension
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.