Skip to content

Conversation

@dwoz
Copy link
Contributor

@dwoz dwoz commented Jul 25, 2023

What does this PR do?

  • Adds recv method to ZeroMQ and TCP transport PublishClients
  • Adds salt.transport.ipc_publish_server and salt.transport.ipc_publish_client factories.
  • Deprecate salt/transport/ipc.py we now use salt/transport/tcp.py for it's functionality
  • Deprecate salt.utils.event.EventPublisher and salt.utils.event.AsyncEventPublisher this functionality is now provided by salt.transport.tcp.TCPPubServer.
  • Use zmq.asyncio instead of zmq.stream for zeromq transport (weaning off tornado where we do not need it)
  • Consolidate tests and migrate ones being touched to pytest.
  • The necessary bits to run salt.transport.zeromq as the ipc transport have been added.
    • We still force the tcp transport for now until saltfactories can work with other transports add test suites are added to the pipelines.

What issues does this PR fix or reference?

Fixes: #64488

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

@dwoz dwoz requested review from a team and s0undt3ch as code owners July 25, 2023 03:44
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Ipc transport merge aio [master] Ipc transport merge aio Jul 25, 2023
@dwoz dwoz changed the title [master] Ipc transport merge aio [master] Merge ipc and tcp transport functionality Jul 25, 2023
@dwoz dwoz added the test:full Run the full test suite label Jul 25, 2023
@dwoz dwoz temporarily deployed to ci July 25, 2023 03:57 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci July 25, 2023 03:57 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci July 25, 2023 03:57 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci July 25, 2023 03:57 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci July 25, 2023 03:57 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci July 25, 2023 03:57 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci July 25, 2023 07:23 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci July 25, 2023 07:23 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci July 25, 2023 07:23 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci July 25, 2023 07:23 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci July 25, 2023 07:23 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci July 25, 2023 07:23 — with GitHub Actions Inactive
@dwoz dwoz force-pushed the ipc_transport_merge_aio branch 6 times, most recently from 39cfa03 to eb797c3 Compare July 25, 2023 09:06
@dwoz dwoz temporarily deployed to ci July 25, 2023 09:25 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci July 25, 2023 09:25 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci July 25, 2023 09:25 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci July 25, 2023 09:25 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci July 25, 2023 09:25 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci July 25, 2023 09:25 — with GitHub Actions Inactive
@dwoz dwoz force-pushed the ipc_transport_merge_aio branch from 10f7378 to 565ec7b Compare August 7, 2023 21:24
@dwoz dwoz temporarily deployed to ci August 7, 2023 21:59 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 7, 2023 21:59 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 7, 2023 21:59 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 7, 2023 21:59 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 7, 2023 21:59 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 7, 2023 21:59 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 8, 2023 03:08 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 8, 2023 03:08 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 8, 2023 03:08 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 8, 2023 03:08 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 8, 2023 03:08 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 8, 2023 03:08 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway merged commit 9a4da7d into master Aug 8, 2023
@garethgreenaway garethgreenaway deleted the ipc_transport_merge_aio branch August 8, 2023 21:47
@dwoz dwoz mentioned this pull request Nov 3, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consolidate ipc "transport" with others

8 participants