-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[master] Merge ipc and tcp transport functionality #64705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0undt3ch
suggested changes
Jul 25, 2023
39cfa03 to
eb797c3
Compare
10f7378 to
565ec7b
Compare
twangboy
approved these changes
Aug 7, 2023
whytewolf
approved these changes
Aug 7, 2023
s0undt3ch
approved these changes
Aug 8, 2023
garethgreenaway
approved these changes
Aug 8, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
salt.transport.ipc_publish_serverandsalt.transport.ipc_publish_clientfactories.salt/transport/ipc.pywe now usesalt/transport/tcp.pyfor it's functionalitysalt.utils.event.EventPublisherandsalt.utils.event.AsyncEventPublisherthis functionality is now provided bysalt.transport.tcp.TCPPubServer.zmq.asyncioinstead ofzmq.streamfor zeromq transport (weaning off tornado where we do not need it)salt.transport.zeromqas the ipc transport have been added.What issues does this PR fix or reference?
Fixes: #64488
Previous Behavior
Remove this section if not relevant
New Behavior
Remove this section if not relevant
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.