Repository navigation
[master] Adding deprecation decorator to the vault modules for 3009. - #64889
Merged
Merged
Conversation
dmurphy18
previously approved these changes
Aug 2, 2023
Ch3LL
suggested changes
Aug 3, 2023
Ch3LL
approved these changes
Aug 17, 2023
MKLeb
approved these changes
Aug 28, 2023
whytewolf
approved these changes
Aug 28, 2023
whytewolf
left a comment
Collaborator
There was a problem hiding this comment.
looks like standard Deprecation.
I3urny
reviewed
Sep 5, 2023
Contributor
There was a problem hiding this comment.
This file should not be in the root directory but in changelog/.
There's also a typo in "deprecated".
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding deprecation decorator to the vault modules for 3009.
What issues does this PR fix or reference?
Fixes: #64893
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.