Skip to content

[master] Adding deprecation decorator to the vault modules for 3009. - #64889

Merged
Ch3LL merged 5 commits into
saltstack:masterfrom
garethgreenaway:deprecate_vault_module
Aug 28, 2023
Merged

Ch3LL merged 5 commits into
saltstack:masterfrom
garethgreenaway:deprecate_vault_module

Conversation

@garethgreenaway

@garethgreenaway garethgreenaway commented Aug 1, 2023 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Adding deprecation decorator to the vault modules for 3009.

What issues does this PR fix or reference?

Fixes: #64893

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway
garethgreenaway requested a review from a team as a code owner August 1, 2023 16:19
@garethgreenaway
garethgreenaway requested review from MKLeb and removed request for a team August 1, 2023 16:19
@salt-project-bot-prod-environment salt-project-bot-prod-environment Bot changed the title Adding deprecation decorator to the vault modules for 3009. [master] Adding deprecation decorator to the vault modules for 3009. Aug 1, 2023
@garethgreenaway
garethgreenaway requested review from a team and dmurphy18 August 1, 2023 16:19
@garethgreenaway
garethgreenaway temporarily deployed to ci August 1, 2023 17:03 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 1, 2023 17:03 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 1, 2023 17:04 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 1, 2023 17:04 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 1, 2023 17:20 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 1, 2023 17:20 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 1, 2023 21:47 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 1, 2023 21:47 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 1, 2023 21:55 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 1, 2023 21:56 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 1, 2023 22:03 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 1, 2023 22:10 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 2, 2023 03:16 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 2, 2023 03:16 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 2, 2023 03:16 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 2, 2023 03:16 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 2, 2023 03:16 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 2, 2023 03:16 — with GitHub Actions Inactive
dmurphy18
dmurphy18 previously approved these changes Aug 2, 2023
Comment thread 64893.dprecated.md Resolved
@garethgreenaway
garethgreenaway temporarily deployed to ci August 10, 2023 16:50 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 10, 2023 17:06 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 10, 2023 17:10 — with GitHub Actions Inactive
@garethgreenaway
garethgreenaway temporarily deployed to ci August 10, 2023 17:12 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 17, 2023 21:49 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 17, 2023 21:49 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 17, 2023 22:09 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 17, 2023 22:10 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 17, 2023 22:31 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 17, 2023 22:33 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 24, 2023 18:56 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 24, 2023 18:56 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 24, 2023 18:56 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 24, 2023 18:56 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 24, 2023 19:15 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 24, 2023 19:17 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 25, 2023 00:28 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 25, 2023 00:28 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 25, 2023 00:28 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 25, 2023 00:28 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 25, 2023 00:28 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci August 25, 2023 00:28 — with GitHub Actions Inactive

@whytewolf whytewolf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like standard Deprecation.

@Ch3LL
Ch3LL merged commit 17abfb4 into saltstack:master Aug 28, 2023
Comment thread 64893.dprecated.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be in the root directory but in changelog/.
There's also a typo in "deprecated".

This branch was previously deployed

1 inactive deployment
ci — 61a7c5ab Deployed Aug 25, 2023 by Ch3LL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TECH DEBT] Deprecate Vault Modules

6 participants