Skip to content

[master] Add MySQL privilege SERVICE_CONNECTION_ADMIN - #64934

Merged
garethgreenaway merged 6 commits into
saltstack:masterfrom
bcremer:add-mysql-SERVICE_CONNECTION_ADMIN-privilege
Oct 24, 2023
Merged

garethgreenaway merged 6 commits into
saltstack:masterfrom
bcremer:add-mysql-SERVICE_CONNECTION_ADMIN-privilege

Conversation

@bcremer

@bcremer bcremer commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

Add MySQL dynamic privilege SERVICE_CONNECTION_ADMIN that was introduced in MySQL 8.0.14.

See:

What does this PR do?

What issues does this PR fix or reference?

Fixes:

Previous Behavior

mysql_grants.present is unable to add the SERVICE_CONNECTION_ADMIN privilege.

New Behavior

mysql_grants.present is able to add the SERVICE_CONNECTION_ADMIN privilege.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@bcremer
bcremer requested a review from a team as a code owner August 8, 2023 07:50
@bcremer
bcremer requested review from whytewolf and removed request for a team August 8, 2023 07:50
@welcome

welcome Bot commented Aug 8, 2023

Copy link
Copy Markdown

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment Bot changed the title Add MySQL privilege SERVICE_CONNECTION_ADMIN [master] Add MySQL privilege SERVICE_CONNECTION_ADMIN Aug 8, 2023

@Ch3LL Ch3LL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a changelog

@garethgreenaway any opinions here on whether we should require test coverage here or not?

@bcremer
bcremer temporarily deployed to ci August 9, 2023 20:31 — with GitHub Actions Inactive
@bcremer
bcremer temporarily deployed to ci August 9, 2023 20:31 — with GitHub Actions Inactive
@bcremer
bcremer temporarily deployed to ci August 9, 2023 20:31 — with GitHub Actions Inactive
@bcremer
bcremer temporarily deployed to ci August 9, 2023 20:31 — with GitHub Actions Inactive
@bcremer
bcremer temporarily deployed to ci August 9, 2023 20:47 — with GitHub Actions Inactive
@bcremer
bcremer temporarily deployed to ci August 9, 2023 20:52 — with GitHub Actions Inactive
@bcremer
bcremer temporarily deployed to ci August 9, 2023 22:00 — with GitHub Actions Inactive
@bcremer
bcremer temporarily deployed to ci August 9, 2023 22:00 — with GitHub Actions Inactive
@bcremer
bcremer temporarily deployed to ci August 9, 2023 22:00 — with GitHub Actions Inactive
@bcremer
bcremer temporarily deployed to ci August 9, 2023 22:00 — with GitHub Actions Inactive
@bcremer
bcremer temporarily deployed to ci August 9, 2023 22:00 — with GitHub Actions Inactive
@bcremer
bcremer temporarily deployed to ci August 9, 2023 22:00 — with GitHub Actions Inactive
@bcremer

bcremer commented Aug 10, 2023

Copy link
Copy Markdown
Contributor Author

Added a changelog file with the PR Number as index. Is that OK or do I need to create a Issue first and assign that number?

@bcremer
bcremer requested a review from Ch3LL August 10, 2023 10:31
Comment thread changelog/64934.changed.md
@Ch3LL

Ch3LL commented Aug 17, 2023

Copy link
Copy Markdown
Contributor

Just added one request and just want to get @garethgreenaway 's review here to see if we would require testing here.

@Ch3LL
Ch3LL requested a review from garethgreenaway August 17, 2023 19:50
@bcremer
bcremer temporarily deployed to ci August 17, 2023 21:10 — with GitHub Actions Inactive
@bcremer
bcremer temporarily deployed to ci August 17, 2023 21:10 — with GitHub Actions Inactive
@bcremer
bcremer temporarily deployed to ci August 17, 2023 21:11 — with GitHub Actions Inactive
@bcremer
bcremer temporarily deployed to ci August 17, 2023 21:26 — with GitHub Actions Inactive
@bcremer
bcremer temporarily deployed to ci August 17, 2023 21:31 — with GitHub Actions Inactive
@bcremer
bcremer temporarily deployed to ci August 17, 2023 21:31 — with GitHub Actions Inactive
@garethgreenaway

Copy link
Copy Markdown
Contributor

I'm good not including tests for this since it's not a potential breaking change and it's simply adding an additional permission type.

@Ch3LL
Ch3LL temporarily deployed to ci October 4, 2023 20:37 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 4, 2023 20:37 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 4, 2023 20:37 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 4, 2023 20:52 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 4, 2023 21:00 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 4, 2023 23:33 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 4, 2023 23:33 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 4, 2023 23:33 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 4, 2023 23:33 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 4, 2023 23:33 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 4, 2023 23:33 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 4, 2023 23:43 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 4, 2023 23:43 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 4, 2023 23:43 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 4, 2023 23:43 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 4, 2023 23:43 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 4, 2023 23:43 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 17, 2023 19:58 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 17, 2023 19:58 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 17, 2023 19:58 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 17, 2023 19:59 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 17, 2023 19:59 — with GitHub Actions Inactive
@Ch3LL
Ch3LL temporarily deployed to ci October 17, 2023 19:59 — with GitHub Actions Inactive
@welcome

welcome Bot commented Oct 24, 2023

Copy link
Copy Markdown

Congratulations on your first PR being merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants