Skip to content

[master] Add MySQL privilege SERVICE_CONNECTION_ADMIN #64934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bcremer
Copy link
Contributor

@bcremer bcremer commented Aug 8, 2023

Add MySQL dynamic privilege SERVICE_CONNECTION_ADMIN that was introduced in MySQL 8.0.14.

See:

What does this PR do?

What issues does this PR fix or reference?

Fixes:

Previous Behavior

mysql_grants.present is unable to add the SERVICE_CONNECTION_ADMIN privilege.

New Behavior

mysql_grants.present is able to add the SERVICE_CONNECTION_ADMIN privilege.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@bcremer bcremer requested a review from a team as a code owner August 8, 2023 07:50
@bcremer bcremer requested review from whytewolf and removed request for a team August 8, 2023 07:50
@welcome
Copy link

welcome bot commented Aug 8, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Add MySQL privilege SERVICE_CONNECTION_ADMIN [master] Add MySQL privilege SERVICE_CONNECTION_ADMIN Aug 8, 2023
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a changelog

@garethgreenaway any opinions here on whether we should require test coverage here or not?

@bcremer bcremer temporarily deployed to ci August 9, 2023 20:31 — with GitHub Actions Inactive
@bcremer bcremer temporarily deployed to ci August 9, 2023 20:31 — with GitHub Actions Inactive
@bcremer bcremer temporarily deployed to ci August 9, 2023 20:31 — with GitHub Actions Inactive
@bcremer bcremer temporarily deployed to ci August 9, 2023 20:31 — with GitHub Actions Inactive
@bcremer bcremer temporarily deployed to ci August 9, 2023 20:47 — with GitHub Actions Inactive
@bcremer bcremer temporarily deployed to ci August 9, 2023 20:52 — with GitHub Actions Inactive
@bcremer bcremer temporarily deployed to ci August 9, 2023 22:00 — with GitHub Actions Inactive
@bcremer bcremer temporarily deployed to ci August 9, 2023 22:00 — with GitHub Actions Inactive
@bcremer bcremer temporarily deployed to ci August 9, 2023 22:00 — with GitHub Actions Inactive
@bcremer bcremer temporarily deployed to ci August 9, 2023 22:00 — with GitHub Actions Inactive
@bcremer bcremer temporarily deployed to ci August 9, 2023 22:00 — with GitHub Actions Inactive
@bcremer bcremer temporarily deployed to ci August 9, 2023 22:00 — with GitHub Actions Inactive
@bcremer
Copy link
Contributor Author

bcremer commented Aug 10, 2023

Added a changelog file with the PR Number as index. Is that OK or do I need to create a Issue first and assign that number?

@bcremer bcremer requested a review from Ch3LL August 10, 2023 10:31
@Ch3LL
Copy link
Contributor

Ch3LL commented Aug 17, 2023

Just added one request and just want to get @garethgreenaway 's review here to see if we would require testing here.

@Ch3LL Ch3LL requested a review from garethgreenaway August 17, 2023 19:50
@bcremer bcremer temporarily deployed to ci August 17, 2023 21:10 — with GitHub Actions Inactive
@bcremer bcremer temporarily deployed to ci August 17, 2023 21:10 — with GitHub Actions Inactive
@bcremer bcremer temporarily deployed to ci August 17, 2023 21:11 — with GitHub Actions Inactive
@bcremer bcremer temporarily deployed to ci August 17, 2023 21:26 — with GitHub Actions Inactive
@bcremer bcremer temporarily deployed to ci August 17, 2023 21:31 — with GitHub Actions Inactive
@bcremer bcremer temporarily deployed to ci August 17, 2023 21:31 — with GitHub Actions Inactive
@garethgreenaway
Copy link
Contributor

I'm good not including tests for this since it's not a potential breaking change and it's simply adding an additional permission type.

@Ch3LL Ch3LL temporarily deployed to ci October 17, 2023 22:25 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 17, 2023 22:26 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 17, 2023 22:26 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 17, 2023 22:26 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 17, 2023 22:26 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 18, 2023 00:29 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 18, 2023 00:29 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 18, 2023 00:30 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 18, 2023 00:30 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 18, 2023 00:30 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 18, 2023 00:30 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 18, 2023 20:38 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 18, 2023 20:38 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 18, 2023 20:40 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 18, 2023 20:40 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 18, 2023 20:40 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 18, 2023 20:41 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 18, 2023 23:43 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 18, 2023 23:44 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 18, 2023 23:44 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 18, 2023 23:44 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 18, 2023 23:45 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci October 18, 2023 23:45 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway merged commit 0cf0214 into saltstack:master Oct 24, 2023
@welcome
Copy link

welcome bot commented Oct 24, 2023

Congratulations on your first PR being merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants