-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[master] Add MySQL privilege SERVICE_CONNECTION_ADMIN #64934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Add MySQL privilege SERVICE_CONNECTION_ADMIN #64934
Conversation
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need a changelog
@garethgreenaway any opinions here on whether we should require test coverage here or not?
Added a changelog file with the PR Number as index. Is that OK or do I need to create a Issue first and assign that number? |
Just added one request and just want to get @garethgreenaway 's review here to see if we would require testing here. |
I'm good not including tests for this since it's not a potential breaking change and it's simply adding an additional permission type. |
Congratulations on your first PR being merged! 🎉 |
Add MySQL dynamic privilege
SERVICE_CONNECTION_ADMIN
that was introduced in MySQL 8.0.14.See:
What does this PR do?
What issues does this PR fix or reference?
Fixes:
Previous Behavior
mysql_grants.present
is unable to add theSERVICE_CONNECTION_ADMIN
privilege.New Behavior
mysql_grants.present
is able to add theSERVICE_CONNECTION_ADMIN
privilege.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.