[master] Add wildcard removal for aptpkg - #65221
Merged
garethgreenaway merged 24 commits intoNov 15, 2023
Merged
Conversation
nicholasmhughes
requested review from
whytewolf
and removed request for
a team
September 18, 2023 15:53
Ch3LL
suggested changes
Sep 18, 2023
Ch3LL
left a comment
Ch3LL
left a comment
Contributor
There was a problem hiding this comment.
Can you also add some functional tests that test the aptpkg and yumpkg code using wildcards to ensure that is also functional?
Contributor
Author
|
@Ch3LL , test failure looks unrelated. can you confirm? |
Contributor
|
yes, we are having issues with the AMI's. This will fix it: #65338 |
Collaborator
|
so, just a thought on this. and this applies to yumpkg as well. we should maybe put in a warning if |
garethgreenaway
approved these changes
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See issue for details
What issues does this PR fix or reference?
Fixes: #65220
Previous Behavior
Wildcards could not be used for apt package removal
New Behavior
Now they can
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.