[master] Dereference symlinks to set proper __cli opt
#65435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
__cli opt__cli opt
dwoz
force-pushed
the
set-proper-__cli
branch
from
f8a0101 to
6c6a6f4
Compare
dwoz
approved these changes
Dec 16, 2023
agraul
pushed a commit
to agraul/salt
that referenced
this pull request
Jan 27, 2025
…#611) * Dereference symlinks to set proper __cli * Add changelog entry * Add unit tests to check path is expanded --------- Co-authored-by: vzhestkov <vzhestkov@suse.com> BACKPORT-UPSTREAM=saltstack#65435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In case of creating symlinks to
salt-call, the behaviour of some modules could be different than expected as__clicontains the name of the symlink instead ofsalt-callitself. This change will dereference the symlinks to set__cliopt to the proper value.Previous Behavior
Different behaviour on calling modules like
state,eventandgitif the call is performed with symlink tosalt-callinstead ofsalt-callitself.New Behavior
The same behaviour for
salt-calland any name of symlink pointint to it as expected.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.