[master] Fix extfs parameter and retcode handling#65687
Merged
dwoz merged 1 commit intosaltstack:masterfrom Dec 12, 2023
Merged
Conversation
nicholasmhughes
requested review from
felippeb
and removed request for
a team
dwoz
force-pushed
the
fix-ability-to-invoke-extfs-properly-with-module.run
branch
from
b23bad0 to
d44969d
Compare
nicholasmhughes
deleted the
fix-ability-to-invoke-extfs-properly-with-module.run
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes various issues. See issues for details.
What issues does this PR fix or reference?
Fixes: #51858
Fixes: #54426
Fixes: #65686
Previous Behavior
65686:
module.runcouldn't detect the tune2fs/mkfs return codesNew Behavior
65686:
module.runcan detect state run result from passingfull_return=Trueto extfs functionsMerge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.