Add Windows support for File operations #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for the minion. Adding in these 2 try statements allows Windows to load the minion.
thatch45
added a commit
that referenced
this pull request
Feb 22, 2012
Add Windows support for File operations
|
Hey Dave, the next time you do a pull request, do you mind rebasing your local branch before pushing? That way you don't have the 7 unnecessary merge commits. Before you start hacking on a feature and with a clean git branch you can do: Then do write your feature and do your local commits. Afterwards run this again: With regard to merging and whatnot, git will do the right thing. If there is a commit upstream, you won't need to run git pull unless it updates files that you are working on. If you want, hit me up on IRC and I would be more than happy to show you how to do this. Other than that very small nit, awesome work. Please do keep the windows support coming. |
arthurzenika
pushed a commit
to arthurzenika/salt
that referenced
this pull request
Sep 17, 2013
Adding new SoftLayer driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.