New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop calling sudo for RVM installs when running as non-root user. #7874

Merged
merged 1 commit into from Oct 16, 2013

Conversation

Projects
None yet
5 participants
@skrobul
Contributor

skrobul commented Oct 16, 2013

I was having problems with deploying non-root installation of RVM and Ruby using salt's rvm module.
It turns out that by default, autolibs will try to elevate privileges if there are some missing packages for requested Ruby version. It does make sense for interactive installations, but fails miserably in scripted environments.
If all dependencies are properly installed it is possible to compile and install new Ruby on a user level without need to elevate privileges. Only thing required to stop RVM from trying to sudo is to disable autolibs and add '--disable-binary'.

I was able to successfully install non-root, user level RVM with compiled ruby on a blank Debian/Ubuntu box.

thatch45 added a commit that referenced this pull request Oct 16, 2013

Merge pull request #7874 from skrobul/rvm_no_sudo
Stop calling sudo for RVM installs when running as non-root user.

@thatch45 thatch45 merged commit 955bc3d into saltstack:develop Oct 16, 2013

@s0undt3ch

This comment has been minimized.

Member

s0undt3ch commented on 347550e Oct 16, 2013

Careful... Mixed tabs with spaces...

@skrobul

This comment has been minimized.

Contributor

skrobul commented Oct 16, 2013

oops, sorry for that. Not sure how it got here. Just comited to the same branch 1727c9f

@thatch45 - can you re-merge this, please?

@skrobul skrobul referenced this pull request Oct 16, 2013

Closed

fix tab/spaces #7890

@ouiea

This comment has been minimized.

Contributor

ouiea commented Oct 21, 2013

Hi there,
When will this fix be released? I'm running 0.17 it and I'm having this same issue when trying to install ruby by rvm.
My /usr/share/pyshared/salt/modules/rvm.py doesn't have this fix.

As a workaround, I'm patching that file by running a patch.sls on the minions :D

Thanks, you rock
H

@basepi

This comment has been minimized.

Member

basepi commented Oct 21, 2013

I think it made it into 0.17.1, but I can't remember for sure off the top of my head. Have you tested with 0.17.1?

@ouiea

This comment has been minimized.

Contributor

ouiea commented Oct 22, 2013

Yes, it's fixed there. I had not see it this morning. Thanks!

@basepi

This comment has been minimized.

Member

basepi commented Oct 22, 2013

Glad to hear it! =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment