Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding close process and service stop to windows installer #8012

Merged
merged 1 commit into from Oct 22, 2013

Conversation

@equinoxefr
Copy link
Contributor

equinoxefr commented Oct 22, 2013

Hi,

Here's a new version of the installer file.

  • Now it cleans cache directory
  • It stops salt-minion service before upgrading
  • It closes salt-minion.exe process (needed if install is launched from salt).

But WARNING there's 2 drawbacks:

  • You need to add nsProcess NSIS plugin
  • Salt can't return when we close salt-minion process :-( but it's needed to upgrade salt-minion.exe

Regards
Pierre

@UtahDave

This comment has been minimized.

Copy link
Member

UtahDave commented Oct 22, 2013

@equinoxefr Very nice! thanks!

Would you mind adding a note to the doc on how to add the nsProcess NSIS plugin?

Thanks for your help!

UtahDave added a commit that referenced this pull request Oct 22, 2013
Adding close process and service stop to windows installer
@UtahDave UtahDave merged commit 9051344 into saltstack:develop Oct 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.