Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Make minion ID caching configurable #8488
I'm new to salt and don't understand why this cached value was added and why its the default.
I'm not sure this is the case... however having an extra minion_id file by default for an edge case most users can ignore seems silly.
Perhaps I just don't understand the problem this cache value solves..?
Ah nm, I see that the minion_id cache only happens when the id is not statically defined in the minion config.
This cache would resolve issues when:
Exactly. We had a regression where the way minion IDs were being resolved was changed, and whole infrastructures lost connection with their master as a result (new minion ID means the master needs to accept the key again).
This cache means that even if the way we "guess" the minion ID changes, existing minion IDs will survive.