From 510778d495ec1c166a2509821390c13e5ca02c04 Mon Sep 17 00:00:00 2001
From: petdance <petdance@0c8536a8-3c1a-0410-a247-91dcf638db7e>
Date: Sun, 25 May 2008 03:35:21 +0000
Subject: [PATCH] lint cleanups

---
 Ack.pm         | 6 +++---
 Changes        | 2 +-
 ack            | 2 +-
 ack-help.txt   | 2 +-
 ack-standalone | 6 +++---
 perlcriticrc   | 2 ++
 t/ack-type.t   | 2 +-
 t/module.t     | 2 +-
 tags           | 2 --
 9 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/Ack.pm b/Ack.pm
index e890ce4..5e555c2 100644
--- a/Ack.pm
+++ b/Ack.pm
@@ -11,14 +11,14 @@ App::Ack - A container for functions for the ack program
 
 =head1 VERSION
 
-Version 1.83_01
+Version 1.84
 
 =cut
 
 our $VERSION;
 our $COPYRIGHT;
 BEGIN {
-    $VERSION = '1.83_01';
+    $VERSION = '1.84';
     $COPYRIGHT = 'Copyright 2005-2008 Andy Lester, all rights reserved.';
 }
 
@@ -351,7 +351,7 @@ sub def_types_from_ARGV {
     ) or App::Ack::die( 'See ack --help or ack --man for options.' );
 
     for my $td (@typedef) {
-        my ($type, $ext) = split '=', $td->[1];
+        my ($type, $ext) = split /=/, $td->[1];
 
         if ( $td->[0] eq 'c' ) {
             # type-set
diff --git a/Changes b/Changes
index 7f770d4..ec9b5f3 100644
--- a/Changes
+++ b/Changes
@@ -1,6 +1,6 @@
 Changelog for ack
 
-NEXT
+1.84
     [ENHANCEMENTS]
     Support color on Windows.  Thanks, Jan Dubois.
 
diff --git a/ack b/ack
index 42dc2ab..241c2d2 100755
--- a/ack
+++ b/ack
@@ -3,7 +3,7 @@
 use warnings;
 use strict;
 
-our $VERSION = '1.83_01';
+our $VERSION = '1.84';
 # Check http://petdance.com/ack/ for updates
 
 # These are all our globals.
diff --git a/ack-help.txt b/ack-help.txt
index fe92ccc..c558138 100644
--- a/ack-help.txt
+++ b/ack-help.txt
@@ -108,4 +108,4 @@ Miscellaneous:
   --version             Display version & copyright
   --thpppt              Bill the Cat
 
-This is version 1.83_01 of ack.
+This is version 1.84 of ack.
diff --git a/ack-standalone b/ack-standalone
index 980312e..327348a 100755
--- a/ack-standalone
+++ b/ack-standalone
@@ -7,7 +7,7 @@
 use warnings;
 use strict;
 
-our $VERSION = '1.83_01';
+our $VERSION = '1.84';
 # Check http://petdance.com/ack/ for updates
 
 # These are all our globals.
@@ -916,7 +916,7 @@ use strict;
 our $VERSION;
 our $COPYRIGHT;
 BEGIN {
-    $VERSION = '1.83_01';
+    $VERSION = '1.84';
     $COPYRIGHT = 'Copyright 2005-2008 Andy Lester, all rights reserved.';
 }
 
@@ -1223,7 +1223,7 @@ sub def_types_from_ARGV {
     ) or App::Ack::die( 'See ack --help or ack --man for options.' );
 
     for my $td (@typedef) {
-        my ($type, $ext) = split '=', $td->[1];
+        my ($type, $ext) = split /=/, $td->[1];
 
         if ( $td->[0] eq 'c' ) {
             # type-set
diff --git a/perlcriticrc b/perlcriticrc
index f43c914..39cf738 100644
--- a/perlcriticrc
+++ b/perlcriticrc
@@ -27,6 +27,8 @@ functions = open opendir read readline readdir close closedir
 
 [-ValuesAndExpressions::ProhibitNoisyQuotes]
 [-ValuesAndExpressions::ProhibitEmptyQuotes]
+[-ValuesAndExpressions::ProhibitMagicNumbers]
+
 
 [-Variables::ProhibitPackageVars]
 [-Variables::ProhibitPunctuationVars]
diff --git a/t/ack-type.t b/t/ack-type.t
index 70b51a2..dad2839 100644
--- a/t/ack-type.t
+++ b/t/ack-type.t
@@ -120,7 +120,7 @@ BUILTIN: {
 
     # check that there is a warning for creating new types with --append_type
     check_stderr( "--type-add foo=.foo --foo",
-        qq{ack-standalone: --type-add: Type "foo" does not exist, creating with ".foo" ...} );
+        q{ack-standalone: --type-add: Type "foo" does not exist, creating with ".foo" ...} );
 }
 
 
diff --git a/t/module.t b/t/module.t
index bad1078..160ee29 100644
--- a/t/module.t
+++ b/t/module.t
@@ -435,7 +435,7 @@ my $iter1;
              32,
              "\n",
              1
-           ]
+           ],
          );
 
     my @e = sort by_2nd @expected;
diff --git a/tags b/tags
index bc4f70b..8390a76 100644
--- a/tags
+++ b/tags
@@ -124,8 +124,6 @@ SEARCH_FOR_DASH_DASH_NOENV	t/ack-env.t	/^SEARCH_FOR_DASH_DASH_NOENV: {$/;"	l
 SINGLE_TEXT_MATCH	t/ack-1.t	/^SINGLE_TEXT_MATCH: {$/;"	l
 SINGLE_TEXT_MATCH_ENV	t/ack-env.t	/^SINGLE_TEXT_MATCH_ENV: {$/;"	l
 SINGLE_TEXT_MATCH_NOENV	t/ack-env.t	/^SINGLE_TEXT_MATCH_NOENV: {$/;"	l
-SKIP	t/ack-passthru.t	/^    SKIP: {$/;"	l
-SKIP	t/context.t	/^    SKIP: {$/;"	l
 SKIP	t/file-permission.t	/^SKIP: {$/;"	l
 SPECIFYING_A_BAK_FILE	t/command-line-files.t	/^SPECIFYING_A_BAK_FILE: {$/;"	l
 STANDARD_GROUPING	t/ack-group.t	/^STANDARD_GROUPING: {$/;"	l