New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build script for Ubuntu 18.04 #1974

Merged
merged 3 commits into from Nov 8, 2018

Conversation

Projects
None yet
3 participants
@awwaiid
Contributor

awwaiid commented Oct 22, 2018

This is a slightly modified version of
https://github.com/nlebellier/autour-de-sonic-pi/blob/master/scripts/build-ubuntu-18-04 . It allowed me to run master on Ubuntu 18.04 with no errors!

In addition to this script, which fixes some dependencies and makes re-building a bit more resilient, I had to:

  • Manually remove my previously cloned aubio checkout (it was complaining about the upstream git repo having been renamed I think)
  • Switch asdf to use the system-python via asdf global python system, since the python3 version in my path was getting a build error for aubio/waf

I welcome testing (or simply a merge; since this is a new file it is pretty low-risk), though note that this won't help if you haven't gotten jack configured correctly. In my case, I was able to run sonic-pi v2.10 from the ubuntu repo without issue. Another thing to beware of is leftover ports being allocated from still-running supercollider and erlang (beam.smp) processes hanging around. I also tested this with ruby 2.3 and 2.5.1 without issue (but with a clean tree in-between).

This change might help with #1913, #1892, #1971, #1805 (this was my core issue), #1809, #1752, maybe others.

@awwaiid awwaiid referenced this pull request Oct 22, 2018

Open

Ubuntu ppa #1892

@rbnpi

This comment has been minimized.

Contributor

rbnpi commented Oct 22, 2018

I tried this on a fresh install of Ubuntu 18.0.4 running on a 10year lod iMac. Worked perfectly.
Two comments.

  1. could install jackd and qjackctl as well
  2. need to give admin password at start of script which is OK, but also again at start of SuperCollider install so can't leave running unattended throughout.

Otherwise great.

@awwaiid

This comment has been minimized.

Contributor

awwaiid commented Oct 22, 2018

I think both are out-of-scope for this PR, but things to be improved for sure. I didn't hit the second one, maybe has to do with sudo timeout?

For this I am going for more of a reach-parity-with-existing-scripts, and this one is very similar to the existing build-ubutu-app script (even moreso than the build-ubuntu-zesty script). Probably all of the ubuntu ones at least should be merged and cleaned up.

@rbnpi

This comment has been minimized.

Contributor

rbnpi commented Oct 22, 2018

I spoke too soon! Testing showed that midi connections weren't working. Investigation showed that the path for the osmid folder in the script was wrong. For Sonic Pi 3.2dev the relative path
OSMID_DIR=${SP_APP_SRC}/../../server/native/linux/osmid
should be
OSMID_DIR=${SP_APP_SRC}/../../server/native/osmid
with this alteration, midi works correctly.

@awwaiid

This comment has been minimized.

Contributor

awwaiid commented Oct 22, 2018

Ah! I had done that manually at one point and forgot! Thanks, change pushed.

Use bash and strict-mode, plus a bugfix
This has at least one bash-specific syntax in it, and strict mode is
nice.

@samaaron samaaron merged commit 6d3e2dd into samaaron:master Nov 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@samaaron

This comment has been minimized.

Owner

samaaron commented Nov 8, 2018

Brilliant stuff, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment