Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `midi_sysex` function for sending variable length System Exclusive MIDi messages #2070

Merged
merged 1 commit into from May 17, 2019

Conversation

Projects
None yet
2 participants
@emlyn
Copy link
Contributor

commented May 15, 2019

I considered making it validate the number of parameters (e.g. ensure 3 bytes for standard messages), but given this is meant for sending raw messages maybe it should let users send invalid MIDI if they want to.

@emlyn

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

Yeah, I think that's a good idea. While the current midi_raw doesn't do anything that midi_sysex wouldn't do, I agree that having two functions would better communicate intent.

In fact, if they are separated, then midi_sysex could validate that the message starts and ends with the correct bytes (0xf0 and 0xf7 respectively).

I'll make that change.

@emlyn emlyn force-pushed the emlyn:sysex branch from f6aa978 to e25dea8 May 16, 2019

@emlyn emlyn changed the title Extend `midi_raw` to allow longer (e.g. Sysex) messages Add `midi_sysex` function for sending variable length System Exclusive MIDi messages May 16, 2019

@emlyn

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

@samaaron I've replaced the previous modification to midi_raw with a separate midi_sysex function, I agree that this is clearer. How does it look to you? Somehow I seem to have obliterated your comment in the process - sorry.

@samaaron samaaron merged commit be4c589 into samaaron:master May 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@samaaron

This comment has been minimized.

Copy link
Owner

commented May 17, 2019

Amazing, thanks!

@emlyn emlyn deleted the emlyn:sysex branch May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.