Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial AD DC Support #28

Merged
merged 16 commits into from
Feb 16, 2022

Conversation

phlogistonjohn
Copy link
Collaborator

While it's a bit rough and simplistic, these changes add AD DC support to sambacc. Currently, there's one new script samba-dc-container that supports one subcommand run. It also has setup actions for provision and join and can also wait for the domain to appear with wait-domain which will poll until the ldap srv record exists for the domain.

With this sambacc supports (by default) the same behavior as the hard-coded scripts in samba-container's ad-server container image. In addition, you can customize your domain and initial users through the sambacc config json. You can then join additional containers to the domain.

I probably could have added more unit tests but the layer between us and samba-tool is thin currently. In the future, some of the stuff like user and groups creation may be better done via function calls into samba's python libs, but right now we just shell out to the cli.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
This can be used to start the AD DC samba server process.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
The samba_cmds module is all about building/prefixing the commands
and we should use it for all the commands we will call.


Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Replace the hard coded stuff brought over from the old shell
scripts.


Signed-off-by: John Mulligan <jmulligan@redhat.com>
This is a nearly direct translation of the previous hard-coded shell
scripts. This is part of a step by step conversion of the ad dc
container to use sambacc. It will be configurable eventually.


Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
This will generate a new script `samba-dc-container` as well as
including the new ad dc example json file.


Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn
Copy link
Collaborator Author

@anoopcs9 @spuiuk PTAL when you have a moment. While there's no huge rush for this I'd also like to make sure it doesn't linger for too long.These changes should not have any impact on the non-DC code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant