Initial AD DC Support #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
This can be used to start the AD DC samba server process. Signed-off-by: John Mulligan <jmulligan@redhat.com>
The samba_cmds module is all about building/prefixing the commands and we should use it for all the commands we will call. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Replace the hard coded stuff brought over from the old shell scripts. Signed-off-by: John Mulligan <jmulligan@redhat.com>
This is a nearly direct translation of the previous hard-coded shell scripts. This is part of a step by step conversion of the ad dc container to use sambacc. It will be configurable eventually. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
This will generate a new script `samba-dc-container` as well as including the new ad dc example json file. Signed-off-by: John Mulligan <jmulligan@redhat.com>
phlogistonjohn
force-pushed
the
jjm-addc
branch
from
d296d2f
to
637a5f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it's a bit rough and simplistic, these changes add AD DC support to sambacc. Currently, there's one new script
samba-dc-containerthat supports one subcommandrun. It also has setup actions forprovisionandjoinand can also wait for the domain to appear withwait-domainwhich will poll until the ldap srv record exists for the domain.With this sambacc supports (by default) the same behavior as the hard-coded scripts in samba-container's ad-server container image. In addition, you can customize your domain and initial users through the sambacc config json. You can then join additional containers to the domain.
I probably could have added more unit tests but the layer between us and samba-tool is thin currently. In the future, some of the stuff like user and groups creation may be better done via function calls into samba's python libs, but right now we just shell out to the cli.