-
-
Notifications
You must be signed in to change notification settings - Fork 18
Closed
Description
First, thanks for the library, this is great!
I noticed when pulling prom.alerts() that our alert state is always coming back undefined (rather than 'firing' or 'pending').
I'm not confident enough to try a patch and PR but I think this is a mixed array call:
prometheus-query-js/src/types.ts
Line 229 in f1a2776
| ResponseType[obj['state']], |
You may have intended for that to reference TargetState?
prometheus-query-js/src/types.ts
Line 299 in f1a2776
| export type TargetState = 'active' | 'dropped' | 'any'; |
and if so TargetState should also include 'firing' and 'pending'
cheers!
Metadata
Metadata
Assignees
Labels
No labels