Event selection dialog loads events dynamically #6
Conversation
Tor runlevels are followed by the rest of the events in the event selection dialog
Dialog was functional but had a few rough edges... * Canceling the dialog didn't work. It still applied any selections we had made due to in-place modifications of our 'initial_selection'. * Simplified our conditionals and dropped the tor_events two dimensional array (unnecessary, and made my head hurt). * Showing the same runlevel names for tor and nyx. Users don't care about our naming differences, and this both looks better and makes them line up. * Moved our 'Ok' and 'Cancel' options to the lower right for consistency. * Use 'T' connectors for the horizontal line. I need to figure out a better option than _addch() but meh. Good enough for now.
Alternate that'll soon be replacing the dialog for selecting events... https://trac.torproject.org/projects/tor/ticket/18499
Using a dynamic rather than static height for our event dialog so it grows and shrinks to match the number of events tor has.
This is something Sambuddha had that I changed, but on reflection his behavior was better. When on the top row of the event dialog and press 'up' leave the cursor where it is (rather than move it to the first position).
Avoiding the small (but very noticeable) delay terminals have by default when pressing the 'esc' key. Caught and fix proposed by patacca.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: