Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use old base image for aarch64 #12

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@campbellr
Copy link

campbellr commented Feb 23, 2019

The latest image is based on Alpine 3.9, which has issues with python3
segfaulting.

This fixes #8

A better long-term fix is probably to switch to using homeassistant/{arch}-base-python for all platforms, since it apparently has a working python3 pre-installed (it doesn't use the version from the alpine repos), but that's a bit more work (the Dockerfile in this project would need some changes).

Use old base image for aarch64
The latest image is based on Alpine 3.9, which has issues with python3
segfaulting.

This fixes #8
@campbellr

This comment has been minimized.

Copy link
Author

campbellr commented Feb 23, 2019

See https://hub.docker.com/r/campbellr/aarch64-googlebackup/ which was built with this change:

 $ uname -a
Linux a0d7b954-ssh 4.14.81-v8 #1 SMP PREEMPT Sun Feb 3 21:35:18 UTC 2019 aarch64 Linux
$  ~ docker run -it campbellr/aarch64-googlebackup:1.5.2 python3 -c 'print("it works")'
it works
@samccauley

This comment has been minimized.

Copy link
Owner

samccauley commented Feb 26, 2019

See https://hub.docker.com/r/campbellr/aarch64-googlebackup/ which was built with this change:

 $ uname -a
Linux a0d7b954-ssh 4.14.81-v8 #1 SMP PREEMPT Sun Feb 3 21:35:18 UTC 2019 aarch64 Linux
$  ~ docker run -it campbellr/aarch64-googlebackup:1.5.2 python3 -c 'print("it works")'
it works

@campbellr Thanks for digging into this. I'll look into re-working my Dockerfile to try to use their python base instead.

@samccauley

This comment has been minimized.

Copy link
Owner

samccauley commented Feb 26, 2019

See https://hub.docker.com/r/campbellr/aarch64-googlebackup/ which was built with this change:

 $ uname -a
Linux a0d7b954-ssh 4.14.81-v8 #1 SMP PREEMPT Sun Feb 3 21:35:18 UTC 2019 aarch64 Linux
$  ~ docker run -it campbellr/aarch64-googlebackup:1.5.2 python3 -c 'print("it works")'
it works

@campbellr I guess I'm going to need a little more help on how to build with that python base. I've been using their build script: https://github.com/home-assistant/hassio-build/tree/master/builder

I can't relate what you're saying to the process I use with their builder.

@campbellr

This comment has been minimized.

Copy link
Author

campbellr commented Feb 27, 2019

Hey @samccauley no problem.

I used that same script to build my image too.

It appears that by default that script just sets the $BUILD_FROM build arg (from your Dockerfile) tohomeassistant/{arch}-base. If instead we override that to use homeassistant/{arch}-base for all architectures (by specifying it in build.json) then we should end up with a working version of python in your image on aarch64 (since that python base image appears to build its own version of python instead of pulling the broken version from the alpine repos).

Take a look at campbellr@bbcf7fb which does this.

(I just created that as an example, i haven't fully tested it because that hassio builder script takes hours on my laptop... It seems to work fine for amd64 though)

Let me know if you want me to close this PR and open up a new one with the above commit.

@samccauley

This comment has been minimized.

Copy link
Owner

samccauley commented Feb 27, 2019

@campbellr I was able to use the python base per your explanation. Thank you. Please give version 1.5.2 of my add-on a try. Let me know how if that works for you on 64 bit hassos.

@campbellr

This comment has been minimized.

Copy link
Author

campbellr commented Mar 2, 2019

Seems to be working. Thanks @samccauley

@campbellr campbellr closed this Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.