Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help me benchmark on your device #337

Closed
samchon opened this issue Nov 14, 2022 · 3 comments
Closed

Help me benchmark on your device #337

samchon opened this issue Nov 14, 2022 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed

Comments

@samchon
Copy link
Owner

samchon commented Nov 14, 2022

By #332 update, typia became much faster. Therefore, I want to re-measure benchmark on multiple devices.

If you want to help this typia project, fork, clone and run below commands. After running the benchmark program, a new directory would be created under benchmark/results following your CPU name. Check the newly generated markdown file and send PR with your new commit.

Whe you're running benchmark on notebook, please process the benchmark program on the charging state. Also, all the benchmarked CPUs are listed up into here: samchon/typia/benchmark/results. It's not forbidden to sending duplicated CPU benchmark PR, such duplicated CPU benchmark would be accepted only when the new benchmark performance is better than previous.

  1. Fork
  2. Clone
  3. npm install
  4. npm run benchmark
  5. Send PR
git clone https://github.com/user-github-account/typia
cd typia
npm install
npm run benchmark

For reference, the benchmark takes about 30 minutes.

Below is an example of the benchmark output, measured on Intel i5-1135g7, Surface Pro 8

Is Function Benchmark

@samchon samchon added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Nov 14, 2022
@samchon samchon self-assigned this Nov 14, 2022
@samchon samchon added this to To do in v3.3 Update via automation Nov 14, 2022
@samchon samchon added this to To do in V5 Update via automation Nov 14, 2022
samchon pushed a commit that referenced this issue Nov 14, 2022
samchon added a commit that referenced this issue Nov 14, 2022
@kakasoo
Copy link
Sponsor Contributor

kakasoo commented Mar 12, 2023

TSError: ⨯ Unable to compile TypeScript:
benchmark/internal/AssertBenchmarker.ts:36:33 - error TS2538: Type 'undefined' cannot be used as an index type.

36                 (output as any)[elem.name] = elem.count / elem.times.elapsed;
                                   ~~~~~~~~~

As a result of executing the command shown above, an error occurs in 'npm run benchmark'. Below is the error code, but I hid the error code because I didn't want my folder structure to be revealed.
If you still want to get the benchmark results, I think you should check it out.

@samchon
Copy link
Owner Author

samchon commented Mar 12, 2023

@kakasoo No AssertBenchmarker class exists more.

I think you're running on previous version of typia (maybe 4 months ago).

What about getting latest commit?

@kakasoo
Copy link
Sponsor Contributor

kakasoo commented Mar 12, 2023

@samchon

Oh, sorry. I used the command above, forgetting that I had previously forked typescript-json (typia). I have an M1 Pro and i7-8 intel core laptop, and if I have free time this week, I will provide a benchmark. ( It's an old laptop, but it's okay, right? )

@samchon samchon closed this as completed Apr 30, 2023
V5 Update automation moved this from To do to Done Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
Development

No branches or pull requests

2 participants