TELEX aliases and various TELEX init ops #1
Conversation
|
Yeah the travis tests are broken because I'm waiting for monome/libavr32#26 to be merged. However... I think the following // TXo Ailiases
const tele_op_t op_TO_TR_P = MAKE_ALIAS_OP(TO.TR.P , op_TO_TR_PULSE_get , NULL, 1, true);
const tele_op_t op_TO_TR_P_DIV = MAKE_ALIAS_OP(TO.TR.P.DIV , op_TO_TR_PULSE_DIV_get , NULL, 2, true);needs to be changed to: // TXo Ailiases
const tele_op_t op_TO_TR_P = MAKE_ALIAS_OP(TO.TR.P , op_TO_TR_PULSE_get , NULL, 1, false);
const tele_op_t op_TO_TR_P_DIV = MAKE_ALIAS_OP(TO.TR.P.DIV , op_TO_TR_PULSE_DIV_get , NULL, 2, false);(last argument has changed from I can make the change if you want. Or you can make the change and rewrite history... (or not if that is easier)
|
|
Oops; I had run the tests but must have buggered something before submitting. Apologies to waste your time. Got a little lost in git nonsense trying to upload the changes - but think I got it. |
|
No worries at all. I'll most likely use the 'squash and merge' option which will handily turn your commits into a single one. |
|
I've squashed and merged the PR. In case you're not quite sure what that means, don't do anymore work on the |
From the changelog:
TO.TR.PforTO.TR.PULSE(plus all sub-commands) andTI.PRMforTI.PARAM(plus all sub-commands)TO.TR.INIT n,TO.CV.INIT n,TO.INIT x,TI.PARAM.INIT n,TI.IN.INIT n, andTI.INIT xMade slight tweak in the readme.md to specify python3 and move the order so that the generator is after the mention of the file it generates from ;)