Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collab texteditor #1

Merged
merged 2 commits into from Dec 27, 2015

Conversation

Projects
None yet
2 participants
@erilyth
Copy link
Contributor

commented Dec 27, 2015

No description provided.

collab.connect('buddy-joined', self.__buddy_joined_cb)
if not hasattr(collab, 'setup_done'):
collab.setup_done = True
collab.setup()

This comment has been minimized.

Copy link
@samdroid-apps

samdroid-apps Dec 27, 2015

Owner

Why do you call collab.setup? Shouldn't that be the activities duty?

Calling collab.setup can cause bad things to happen if it called before the activity is ready, so it is important that it gets called at only the right time.

This comment has been minimized.

Copy link
@erilyth

erilyth Dec 27, 2015

Author Contributor

Ah great! That would resolve the problems of having to call it just once etc :D

@erilyth

This comment has been minimized.

Copy link
Contributor Author

commented Dec 27, 2015

Remove the collab setup, so the activity can take care of it

@samdroid-apps samdroid-apps merged commit 93670b2 into samdroid-apps:master Dec 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.