Fix format scopes, they should be of type /auth/#{scope} #4

Merged
merged 1 commit into from Mar 25, 2013

Conversation

Projects
None yet
4 participants
@gaizka
Contributor

gaizka commented Mar 25, 2013

Scopes should be based on /auth/, no /auth/userinfo.

According to https://developers.google.com/+/api/oauth#scopes, valid
scopes are:

- https://www.googleapis.com/auth/plus.login
- https://www.googleapis.com/auth/plus.me
- https://www.googleapis.com/auth/userinfo.email

So you should not scopes start with userinfo. ...

@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Mar 25, 2013

Coverage remained the same when pulling 47656b1 on gaizka:fix-format-scopes into cb66836 on krainboltgreene:master.

View Details

Coverage remained the same when pulling 47656b1 on gaizka:fix-format-scopes into cb66836 on krainboltgreene:master.

View Details

@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Mar 25, 2013

Coverage remained the same when pulling 47656b1 on gaizka:fix-format-scopes into cb66836 on krainboltgreene:master.

View Details

Coverage remained the same when pulling 47656b1 on gaizka:fix-format-scopes into cb66836 on krainboltgreene:master.

View Details

@samdunne

This comment has been minimized.

Show comment Hide comment
@samdunne

samdunne Mar 25, 2013

Owner

I'm happy to merge this if @krainboltgreene is

Owner

samdunne commented Mar 25, 2013

I'm happy to merge this if @krainboltgreene is

@krainboltgreene

This comment has been minimized.

Show comment Hide comment
@krainboltgreene

krainboltgreene Mar 25, 2013

Contributor

👍

Contributor

krainboltgreene commented Mar 25, 2013

👍

samdunne added a commit that referenced this pull request Mar 25, 2013

Merge pull request #4 from gaizka/fix-format-scopes
Fix format scopes, they should be of type /auth/#{scope}

@samdunne samdunne merged commit 879fc77 into samdunne:master Mar 25, 2013

1 check passed

default The Travis build passed
Details
@samdunne

This comment has been minimized.

Show comment Hide comment
@samdunne

samdunne Mar 25, 2013

Owner

Merged. Just wait for @krainboltgreene to release the new gem version ;)

Owner

samdunne commented Mar 25, 2013

Merged. Just wait for @krainboltgreene to release the new gem version ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment