Sam Dutton samdutton

Organizations

GoogleChrome HTML5Rocks
Sam Dutton
Sam Dutton
samdutton merged pull request webrtc/samples#486
Sam Dutton
filetransfer: blow away all previous state and restart
2 commits with 20 additions and 7 deletions
samdutton commented on issue webrtc/samples#485
Sam Dutton

+1 Just thinking the same. @fippo

samdutton commented on pull request webrtc/samples#483
Sam Dutton

webrtc.github.io/samples/src/content/datachannel/filetransfer Duly tweeted, G+ posted, and included in forthcoming blog post about the samples repo.

Sam Dutton
Sam Dutton
Sam Dutton
Sam Dutton
samdutton merged pull request webrtc/samples#483
Sam Dutton
filetransfer: show bitrate stats
11 commits with 114 additions and 16 deletions
samdutton commented on pull request webrtc/samples#483
Sam Dutton

Fantastic! Merged.

samdutton commented on pull request webrtc/samples#483
Sam Dutton

Nice. LGTM aside from nitpick. Could maybe display the bitrate every 100ms - I only saw it flash up once with a ~6MB file. On 26 February 2015 at 1…

samdutton commented on pull request webrtc/samples#483
Sam Dutton

Add a line space above this in the code – and with CSS for the layout :).

Sam Dutton
Sam Dutton
  • Christoffer Jansson fec5ab5
    Merge pull request #482 from samdutton/master
Sam Dutton
  • Christoffer Jansson fec5ab5
    Merge pull request #482 from samdutton/master
samdutton commented on pull request webrtc/samples#483
Sam Dutton

How about average bitrate calculated as file.size / time-it-takes-to-transfer? Perfect. BTW - do you want to add a sentence or two that explains …

samdutton commented on pull request webrtc/samples#483
Sam Dutton

Nice one! I noticed that the bitrate won't display for files that transfer in less than a second (the setInterval interval). Reducing the interva…

samdutton commented on pull request webrtc/samples#482
Sam Dutton

@KaptenJansson or @jiayliu – could you give this a quick once over? Thanks.

samdutton opened pull request webrtc/samples#482
Sam Dutton
Tweaks for RTCDataChannel file transfer example
1 commit with 12 additions and 10 deletions
Sam Dutton
Sam Dutton
Sam Dutton
Sam Dutton
samdutton merged pull request webrtc/samples#481
Sam Dutton
add filetransfer demo
9 commits with 275 additions and 6 deletions
samdutton commented on pull request webrtc/samples#481
Sam Dutton

LGTM

samdutton commented on pull request webrtc/samples#481
Sam Dutton

LGTM % nits. Thanks again for doing this. Will also ask Benjamin Schwartz to take a look.

samdutton commented on pull request webrtc/samples#481
Sam Dutton

We've just started using JSCS validation with "preset": "google". This adds a few validation rules such as only allowing one var declaration per line.

samdutton commented on pull request webrtc/samples#481
Sam Dutton

Could you add a little more space (margin: 0 0 1em 0) between each or these lines? If you can be bothered, maybe put the progress elements on the s…

samdutton commented on pull request webrtc/samples#481
Sam Dutton

Link should be to https://webrtc.github.io/samples/ (Just fixed this elsewhere.)