Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed. `GitLab: Disallowed command` when ssh test command #1959

Open
wants to merge 2 commits into
base: master
from

Conversation

@sue445
Copy link
Contributor

sue445 commented Jul 18, 2019

When ssh test command (e.g. ssh -T git@gitlab.example.com ) is executed, $SSH_ORIGINAL_COMMAND is empty.

If empty $SSH_ORIGINAL_COMMAND is passed to gitlab-shell in container, ssh test is failed

Expected

$ ssh -T git@gitlab.example.com
Welcome to GitLab, @sue445!

Actual

$ ssh -T git@gitlab.example.com
> GitLab: Disallowed command

So I tried not to pass empty $SSH_ORIGINAL_COMMAND into container.

When ssh test command (e.g. `ssh -T git@gitlab.example.com` ) is executed, `$SSH_ORIGINAL_COMMAND` is empty.

If empty `$SSH_ORIGINAL_COMMAND` is passed to gitlab-shell in container, ssh test is failed

Expected

```bash
$ ssh -T git@gitlab.example.com
Welcome to GitLab, @sue445!
```

Actual

```bash
$ ssh -T git@gitlab.example.com
> GitLab: Disallowed command
```

So I tried not to pass empty `$SSH_ORIGINAL_COMMAND` into container.
@sue445 sue445 force-pushed the sue445:fix-expose-gitlab-ssh-port-sh branch 2 times, most recently from 6a6419f to 74808df Jul 18, 2019
https://circleci.com/gh/sameersbn/docker-gitlab/740

```
Too long with no output (exceeded 10m0s)
```

docker build time is too long...
@sue445 sue445 force-pushed the sue445:fix-expose-gitlab-ssh-port-sh branch from 74808df to a8415fc Jul 18, 2019
@sue445

This comment has been minimized.

Copy link
Contributor Author

sue445 commented Sep 10, 2019

Is there anything I can do for this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.