functions: Fix tx isolation detection

Fixes: #550
sameersbn · Mar 28, 2024 · 6ab357c · 6ab357c
1 parent f3dc70d
commit 6ab357c
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/assets/runtime/functions b/assets/runtime/functions
@@ -261,15 +261,13 @@ redmine_check_mysql_database_tx_isolation() {
           --user "${DB_USER}" --default-character-set "${DB_ENCODING}" \
           --skip-column-names \
           --silent "
-    isolation_lvl=$( MYSQL_PWD="${DB_PASS}" $mysql_cmd \
+    if ! isolation_lvl=$( MYSQL_PWD="${DB_PASS}" $mysql_cmd \
           --execute="SELECT @@GLOBAL.tx_isolation;" )
-
-    if [[ $? -ne 0 ]]; then
+    then
       # try the new name of the variable, mysql 8+
-      isolation_lvl=$( MYSQL_PWD="${DB_PASS}" $mysql_cmd \
+      if ! isolation_lvl=$( MYSQL_PWD="${DB_PASS}" $mysql_cmd \
             --execute="SELECT @@GLOBAL.transaction_isolation;" )
-
-      if [[ $? -ne 0 ]]; then
+      then
         echo
         echo "ERROR: Failed to check transaction isolation level" >&2
         return 1