Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra instructions #11

Merged
merged 4 commits into from Mar 11, 2019
Merged

Infra instructions #11

merged 4 commits into from Mar 11, 2019

Conversation

samhstn
Copy link
Owner

@samhstn samhstn commented Mar 11, 2019

Fixes #10

@samhstn samhstn self-assigned this Mar 11, 2019
@samhstn samhstn assigned samhstn and unassigned samhstn Mar 11, 2019
Effect: Allow
Principal: "*"
Action: s3:GetObject
Resource: !Join ["", ["arn:aws:s3:::www.", !Ref DomainName, "/*"]]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shame this repeated block can't be just written once 🤔

Copy link
Collaborator

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samhstn these are quite the improvements! Looks good. 👍

@nelsonic nelsonic merged commit 2877166 into master Mar 11, 2019
@nelsonic nelsonic deleted the infra-instructions#10 branch March 11, 2019 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants