Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'View" button for previewing custom post types should use 'view_item' label defined when custom post type is registered #31

Closed
spinfly opened this issue Nov 19, 2019 · 1 comment
Assignees
Milestone

Comments

@spinfly
Copy link

spinfly commented Nov 19, 2019

Currently, the "View ..." button on admin pages uses ucfirst( $post->post_type ). This looks clunky when usings a custom post type like 'press_releases'. See attached screenshot.

My recommendation is to use the 'view_item' label that is defined when a post type is registered for this button.

The code to be modified is here:

custom-permalinks/frontend/class-custom-permalinks-form.php
Lines 180 and 238

@samiahmedsiddiqui
Copy link
Owner

samiahmedsiddiqui commented Apr 3, 2020

@spinfly Done, sorry I didn't review this issue before, just fixed and will available in the upcoming in the next few days.

@samiahmedsiddiqui samiahmedsiddiqui added this to the 2.0.0 milestone Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants