Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the prefix for the main Slack window #3

Merged
merged 1 commit into from Mar 11, 2020

Conversation

alexrepty
Copy link
Contributor

@alexrepty alexrepty commented Mar 3, 2020

Slack Version 4.3.3 (and possibly before) uses a pipe instead of a dash for the main window, so this commit addresses that.

Changes this:

on «event SLAKMNWN»
	chooseWindow("Slack -")
end «event SLAKMNWN»

to this:

on «event SLAKMNWN»
	chooseWindow("Slack | ")
end «event SLAKMNWN»

Since that appears to be what Slack uses nowadays:

Bildschirmfoto 2020-03-03 um 20 51 57

Slack Version 4.3.3 (and possibly before) uses a pipe instead of a dash for the main window, so this commit addresses that.
@alexrepty
Copy link
Contributor Author

@alexrepty alexrepty commented Mar 10, 2020

@samknight Sorry, totally forgot to ping you about this. This change is needed to get the AppleScript definitions working again with a current version of Sketch, since the limiter changed. Would you like to review and merge?

@samknight
Copy link
Owner

@samknight samknight commented Mar 11, 2020

Apologies. I didn't didn't get alerted to the PR. I'm going to test this out now.

Thanks for updating!

@samknight samknight merged commit ac3c2b1 into samknight:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants