Skip to content

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
Checking mergeability… Don’t worry, you can still create the pull request.
Commits on Feb 23, 2012
@kastashov kastashov Add custom release criteria for topics/weeks cf5f0d2
Commits on Feb 28, 2012
@kastashov kastashov CRCTW: Fix lang string dependencies 41b54ba
@kastashov kastashov CRCTW: Fix upgrade.php 7231f4f
@kastashov kastashov CRCTW: Add speedup condition to lib/navigationlib.php a858d99
@kastashov kastashov CTCTW: fix lib/db/upgrade.php to allow null values in certain fields a2f4cd3
@kastashov kastashov CRCTW: items 10, 12, 13, 16, 18 of the review 9fb3704
@kastashov kastashov CRCTW: item 16, fix incorrect argument in editsection.php 1526d41
Commits on Mar 07, 2012
@kastashov kastashov CRCTW: Fix modules add/edit save not working 32d646d
Commits on Mar 09, 2012
@kastashov kastashov CRCTW: Fix activities not obeying grouping access

@kastashov kastashov CRCTW: Fix wrong type quote unintentionally added in the previous commit b20baa7
Commits on Mar 13, 2012
@luke-tucker luke-tucker CRCTW: Refresh secinfo after module instance duplicated to ensure new…
… instance is displayed in course page immediately
Commits on Mar 14, 2012
@kastashov kastashov UNSW2-75: Fix viewing courses which have no sections yet 4f717ab
Commits on Mar 16, 2012
@kastashov kastashov UNSW2-75: Amend access conditions to topics/weeks

@kastashov kastashov CRCTW: Fix moving modules in a course (AJAX) not working 6148325
Commits on Mar 21, 2012
@sammarshallou Merge commit '6148325f9d5d2efbe1d07cfc7accf1ab9c44ed4e' into MDL-2441…

Commits on Mar 23, 2012
@sammarshallou Change from using object-type variable to two classes. b76f00b
@sammarshallou Grade condition does not work if you leave a box blank e0439b2
Commits on Mar 26, 2012
@sammarshallou Moved section cache code into modinfolib, and reduced size of cached …
@sammarshallou Fixed section availability to be analogous to cm availability, and ap…
…ply to included sections
Commits on Mar 27, 2012
@sammarshallou Tidying up
- Tidied whitespace, wrapping, etc.
- Removed impossible code branches.
- Removed duplicated code in editsection and refactored
update_cm_from_form so it could be shared.
- Made it so grouping option only appears if you've enabled
groupmembersonly (consistent with activity behaviour)
- Removed double-checks in formats for section already existing due to
cache being wrong (this shouldn't happen - in case it does, I filed
MDL-32215 so it can be detected).
- Removed course/modedit change about using a variable instead of just
passing a temp array, and course/moodleform_mod.php whitespace
correction, because there doesn't seem really to be a need to touch
either file.
- There was a possible serious performance problem with changes to
completion_value_used_as_condition, which I believe may be called
multiple times per page, but the new code makes a database query. I have
changed it to use entirely cached data without any queries.
- There was no index on the course_sections_availability table in
install.xml (but there was one in the upgrade). I changed it to have the
same set of keys/indexes as course_modules_availability. Also generally
updated install.xml changes to match current 2.3 format (this was
changed slightly).
Commits on Mar 30, 2012
@sammarshallou Made it display grouping information same way that activities do, it …
…was inconsistent.

Also moved caching for grouping data from course/lib.php into the groups_ function.
@sammarshallou Backup core change: restore_structure_step to have after_restore method dfbc89d
@sammarshallou Backup and restore support 7dcb03c
@sammarshallou Did not delete course_sections_availability records when deleting course ad981e2
Commits on Apr 02, 2012
@sammarshallou Removed stupid debug code 06bdb31