Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] websocket keeplive callback #433

Conversation

zig2015
Copy link
Contributor

@zig2015 zig2015 commented Sep 24, 2019

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.437% when pulling 80b98a3 on shawhen:master into c4fdad5 on sammchardy:master.

@goldan
Copy link
Contributor

goldan commented Oct 16, 2019

Please take a look at #440. I fixed the same bug and also the timer restart functionality.

@sammchardy sammchardy changed the base branch from master to bugfix/fix-websocket-keepalive-callback February 6, 2020 09:15
@sammchardy sammchardy merged commit 83e9622 into sammchardy:bugfix/fix-websocket-keepalive-callback Feb 6, 2020
@sammchardy
Copy link
Owner

Thanks @zig2015

@eltintin93
Copy link

Hello,
I have the same problem.
Is this commit merged in the master branch finally to solve the bug.
I confess I am not sure of the use.
Is it necessary to enter some parameters in particular?
I thank you for your help.
Sincerely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants