Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Remove the automatic call to RSpec.reset

This also updates the specs that are effected by this call. The order
specs were effected because the RSpec runner was being invoked within
the same ruby process (I think). The run_command helper in the
order_spec file has been updated to explicitly invoke the reset method.

Signed-off-by: Sam Phippen <samphippen@googlemail.com>
  • Loading branch information...
commit d6d0d359627c057ef81c9a5d2bb9397604c363df 1 parent 336f201
Sam Phippen authored
2  lib/rspec/core/runner.rb
View
@@ -68,8 +68,6 @@ def self.run(args, err=$stderr, out=$stdout)
else
CommandLine.new(options).run(err, out)
end
- ensure
- RSpec.reset
end
end
end
1  spec/command_line/order_spec.rb
View
@@ -194,6 +194,7 @@ def split_in_half(array)
def run_command(cmd)
RSpec::Core::Runner.run(cmd.split, stderr, stdout)
+ RSpec.reset
end
def run_command_expecting_error(cmd)
6 spec/rspec/core/runner_spec.rb
View
@@ -26,12 +26,6 @@ module RSpec::Core
let(:err) { StringIO.new }
let(:out) { StringIO.new }
- it "tells RSpec to reset" do
- RSpec.configuration.stub(:files_to_run => [])
- RSpec.should_receive(:reset)
- RSpec::Core::Runner.run([], err, out)
- end
-
context "with --drb or -X" do
before(:each) do
Please sign in to comment.
Something went wrong with that request. Please try again.