New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quality option to vimeo parameters #1186

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@flipswitchingmonkey

flipswitchingmonkey commented Sep 14, 2018

Vimeo supports default quality settings for embeds, see https://help.vimeo.com/hc/en-us/articles/224983008-Setting-default-quality-for-embedded-videos
As such, quality settings of 4K, 2K, 1080p, 720p, 540p, and 360p are valid.

Link to related issue (if applicable)

Summary of proposed changes

Checklist

  • Use develop as the base branch
  • Exclude the gulp build (/dist changes) from the PR
  • Test on supported browsers
add quality option to vimeo parameters
Vimeo supports default quality settings for embeds, see https://help.vimeo.com/hc/en-us/articles/224983008-Setting-default-quality-for-embedded-videos
As such, quality settings of 4K, 2K, 1080p, 720p, 540p, and 360p are valid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment