Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope the .button class to be .shr-button #8

Closed
danpastori opened this issue Oct 1, 2018 · 2 comments
Closed

Scope the .button class to be .shr-button #8

danpastori opened this issue Oct 1, 2018 · 2 comments

Comments

@danpastori
Copy link
Contributor

Problem

When using Shr in a framework such as Foundation or Bootstrap, the .button CSS class
used to render Shr is bombarded with unwanted class styles that overwrite the Shr
styles.

Rationale

Frameworks such as Bootstrap and Foundation are very common and utilize the .button
class to style HTML elements. Shr uses this too. The problem is that the two classes
conflict with each other allowing the Shr buttons not to render correctly.

Solution

I'll re-scope the .button class to be .shr-button.

Pros of Solution:

  • Can make Shr framework agnostic and be able to be used in all frameworks.

Cons of Solution

  • Breaking change that would require the user to update CSS classes to be .shr-button

If you'd like to move forward, let me know and I'll submit a PR!

@sampotts
Copy link
Owner

sampotts commented Oct 2, 2018

Seems very logical to me. Go for it 👍

@sampotts
Copy link
Owner

I've also made the count .shr-count by default in 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants