Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album dirty tracking should be less aggressive #856

Closed
sampsyo opened this issue Jul 2, 2014 · 0 comments
Closed

Album dirty tracking should be less aggressive #856

sampsyo opened this issue Jul 2, 2014 · 0 comments
Labels
bug bugs that are confirmed and actionable
Milestone

Comments

@sampsyo
Copy link
Member

sampsyo commented Jul 2, 2014

As pointed out in #853, recent refactoring has broken a behavior in album-level metadata modifications. If, for example, an album has field foo equal to bar, then beet mod foo=bar is a no-op due to dirty tracking. This is problematic when the tracks have inconsistent data—it would be good for this change to propagate to the tracks even when no change has made.

This means we need to change the way dirty tracking works for the Album class to consider a field dirty on assignment, even when the new value equals the old value.

@sampsyo sampsyo added the bug label Jul 2, 2014
@sampsyo sampsyo added this to the 1.3.7: More Types milestone Jul 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Development

No branches or pull requests

1 participant