Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
🎉 Support for `included` query param in JsonApiSerializer #424
1. Updated JsonApiSerializer to use dasherized types
JSONAPI recommends to use dasherized types. Though not a strict requirement, that's what Ember uses. Ember ignores camel-cased types.
2. Updated serializer relationships to use dasherized strings rather than camelized
You said the convention is to use camel case in property keys and dashes in strings. It sucked to write
3. Support for
changed the title
:tada: Support for `included` query param in JsonApiSerializer
Dec 10, 2015
I've pushed my wip branch so we can compare what I was doing with what you've done here. There's a lot going on in both branches.
Ok, if you agree + revert the kebab-casing of the relationships array, I think this is good to go!
Thanks for the update! Some comments:
This PR is now very large, and it's taken me a long time to review both of the bigger sets of changes you've made to it. The dasherize issues addressed here are at the top of my queue, and they're a blocker for the next set of issues I need to tackle.
I'm going to ask that you revert the includes queryParam changes here (you should check out a new branch so you can rebase once we get this merged, so you don't lose your work, and if you want to continue working on that feature in the future), as well as the serialization-by-default issues mentioned above, so we can merge this in. Otherwise, I'm going to need to close this, so I can finish my implementation at #428 and press on towards 0.2.0.
I reviewed everything, great work (again)! I'm glad you made the change to json:api so all
The one thing that remains is, to standardize names across JSONAPISerializer and BaseSerializer. You changed JSONAPISerializer to
I'm happy to merge this, then make the change myself, if you'd like to just get this in, so we can be done with it! Or, you can make the change. What do you think?